Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Size values in benchmarking results seems inaccurate #184

Closed
katxiao opened this issue Jan 19, 2023 · 0 comments · Fixed by #185
Closed

Size values in benchmarking results seems inaccurate #184

katxiao opened this issue Jan 19, 2023 · 0 comments · Fixed by #185
Assignees
@katxiao
Labels
bug Something isn't working
Milestone
0.6.0

Comments

@katxiao
Copy link
Contributor

katxiao commented Jan 19, 2023

Environment Details

The sizes for dataset size and synthesizer size (in MB) seems to be very low.

For small datasets, it's reporting model size to be 0.046KB. It seems a couple orders of magnitude off. We should double check that we are computing the size of these objects correctly.
@katxiao katxiao added the bug Something isn't working label Jan 19, 2023
@katxiao katxiao self-assigned this Jan 19, 2023
@katxiao katxiao mentioned this issue Jan 19, 2023
Merged
@npatki npatki added this to the 0.6.0 milestone Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katxiao katxiao

Labels
bug Something isn't working
Projects
None yet
Milestone
0.6.0
Development

Successfully merging a pull request may close this issue.

Add s3 prefix and fix get size sdv-dev/SDGym
2 participants
@katxiao @npatki