Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the file names inside the detailed_results_folder #191

Closed
npatki opened this issue Jan 20, 2023 · 0 comments · Fixed by #200
Closed

Simplify the file names inside the detailed_results_folder #191

npatki opened this issue Jan 20, 2023 · 0 comments · Fixed by #200
Assignees
Labels
feature request Request for a new feature
Milestone

Comments

@npatki
Copy link

npatki commented Jan 20, 2023

Version: 0.8.0 (in development)

Problem Description

If I provide a detailed_results_folder, the items in that folder have very long names. That seem to follow the format:

<synthesizer_name>_<dataset_name>_<iteration_num>_<run_id>_data.gz
<synthesizer_name>_<dataset_name>_<iteration_num>_<run_id>_scores.csv

Example:

results_folder/
|-- GaussianCopulaSynthesizer_alarm_1_181232_data.gz
|-- GaussianCopulaSynthesizer_alarm_1_181232_scores.csv

But due to the changes we are making, iteration_num and run_id are not really needed. Especially if we enforce that synthesizers are unique (see #190)

Expected behavior

Remove the iteration_num and run_id information from the file names. The resulting file names should be shorter & simpler.

results_folder/
|-- GaussianCopulaSynthesizer_alarm_data.gz
|-- GaussianCopulaSynthesizer_alarm_scores.csv
@npatki npatki added the feature request Request for a new feature label Jan 20, 2023
@katxiao katxiao self-assigned this Feb 1, 2023
@katxiao katxiao added this to the 0.6.0 milestone Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants