Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup SDGym to the new SDV 1.0 metadata and synthesizers #212

Closed
npatki opened this issue Mar 29, 2023 · 0 comments · Fixed by #213
Closed

Cleanup SDGym to the new SDV 1.0 metadata and synthesizers #212

npatki opened this issue Mar 29, 2023 · 0 comments · Fixed by #213
Assignees
@fealho
Labels
feature request Request for a new feature maintenance Tasks related to infrastructure & dependencies
Milestone
0.7.0

Comments

@npatki
Copy link

npatki commented Mar 29, 2023 •
edited
Loading

Problem Description

Since we've upgraded to SDV 1.0, the synthesizer class names and metadata formats have changed. The SDGym is currently written assuming that SDV < 1.0 (even though the official requirements are anything >=0.18.0).

We should fix this asap.

Expected behavior

Use the synthesizers, datasets and metadata as provided by the SDV 1.0 library.

We should also update the minimum and maximum to: sdv >1.0 and sdv < 2.0
@npatki npatki added feature request Request for a new feature maintenance Tasks related to infrastructure & dependencies labels Mar 29, 2023
This was referenced Mar 31, 2023
Merged
Closed
Closed
@amontanez24 amontanez24 added this to the 0.7.0 milestone Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fealho fealho

Labels
feature request Request for a new feature maintenance Tasks related to infrastructure & dependencies
Projects
None yet
Milestone
0.7.0
Development

Successfully merging a pull request may close this issue.

Update SDGym to work with SDV 1.0.0 sdv-dev/SDGym
Base PR for supporting SDV 1.0 sdv-dev/SDGym
3 participants
@npatki @amontanez24 @fealho