Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passing synthesizer as string fails if run_on_ec2 is enabled #306

Closed
amontanez24 opened this issue Jun 4, 2024 · 0 comments · Fixed by #307
Closed

Passing synthesizer as string fails if run_on_ec2 is enabled #306

amontanez24 opened this issue Jun 4, 2024 · 0 comments · Fixed by #307
Assignees
@lajohn4747
Labels
bug Something isn't working
Milestone
0.8.0

Comments

@amontanez24
Copy link
Contributor

Environment Details

Please indicate the following details about the environment in which you found the bug:

  • SDGym version: 0.8.0.dev0
  • Python version:
  • Operating System:

Error Description

When running benchmark_single_table, if run_on_ec2 is enabled, the synthesizers can't be passed in as strings. If they are, it crashes

Steps to reproduce

from sdv.single_table import GaussianCopulaSynthesizer

results = sdgym.benchmark_single_table(
    synthesizers=['GaussianCopulaSynthesizer'],
    output_filepath='s3://sdgym-benchmark/Results/06-04-2024-GaussianCopulaSynthesizer.csv',
    detailed_results_folder='s3://sdgym-benchmark/Details/',
    run_on_ec2=True
)
@amontanez24 amontanez24 added the bug Something isn't working label Jun 4, 2024
@amontanez24 amontanez24 added this to the 0.8.0 milestone Jun 4, 2024
@lajohn4747 lajohn4747 self-assigned this Jun 5, 2024
@lajohn4747 lajohn4747 mentioned this issue Jun 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lajohn4747 lajohn4747

Labels
bug Something isn't working
Projects
None yet
Milestone
0.8.0
Development

Successfully merging a pull request may close this issue.

Allow strings to run with ec2 sdv-dev/SDGym
2 participants
@amontanez24 @lajohn4747