Skip to content
This repository has been archived by the owner on Sep 16, 2024. It is now read-only.

Support catalog/template/schema controller and apis #2268

Merged
merged 6 commits into from
Apr 12, 2024
Merged

Support catalog/template/schema controller and apis #2268

merged 6 commits into from
Apr 12, 2024

Conversation

aiwantaozi
Copy link
Contributor

No description provided.

@aiwantaozi aiwantaozi force-pushed the dev-michelia3 branch 3 times, most recently from 0d956d9 to c08496f Compare April 10, 2024 06:55
gitlawr
gitlawr reviewed Apr 11, 2024
View reviewed changes
pkg/apis/walruscore/v1/condition.go Show resolved Hide resolved
pkg/apis/walruscore/v1/condition_summary.go Outdated Show resolved Hide resolved
pkg/apis/walruscore/v1/condition_summary.go Show resolved Hide resolved
pkg/apis/walruscore/v1/catalog.go Outdated Show resolved Hide resolved
pkg/apis/walruscore/v1/catalog.go Outdated Show resolved Hide resolved
pkg/apis/walruscore/v1/catalog.go Outdated Show resolved Hide resolved
pkg/apis/walruscore/v1/template.go Show resolved Hide resolved
gitlawr
gitlawr reviewed Apr 11, 2024
View reviewed changes
pkg/server/option.go Outdated Show resolved Hide resolved
pkg/systemkuberes/catalog.go Outdated Show resolved Hide resolved
thxCode
thxCode suggested changes Apr 11, 2024
View reviewed changes
pkg/apis/walruscore/v1/condition.go Outdated Show resolved Hide resolved
pkg/apis/walruscore/v1/condition.go Outdated Show resolved Hide resolved
pkg/apis/walruscore/v1/condition_summary.go Outdated Show resolved Hide resolved
pkg/apis/walruscore/v1/condition.go Outdated Show resolved Hide resolved
pkg/systemmeta/annotations.go Outdated Show resolved Hide resolved
gitlawr
gitlawr reviewed Apr 11, 2024
View reviewed changes
pkg/controllers/walruscore/template.go Outdated Show resolved Hide resolved
pkg/extensionapis/walrus/catalog.go Outdated Show resolved Hide resolved
@aiwantaozi aiwantaozi force-pushed the dev-michelia3 branch 2 times, most recently from fcdc8c6 to 4e31dc8 Compare April 11, 2024 14:52
thxCode
thxCode reviewed Apr 12, 2024
View reviewed changes
pkg/systemmeta/labels.go Outdated Show resolved Hide resolved
thxCode
thxCode reviewed Apr 12, 2024
View reviewed changes
pkg/systemmeta/labels.go Outdated Show resolved Hide resolved
thxCode
thxCode reviewed Apr 12, 2024
View reviewed changes
pkg/systemmeta/labels.go Outdated Show resolved Hide resolved
@aiwantaozi aiwantaozi force-pushed the dev-michelia3 branch 2 times, most recently from dbdca87 to e37a9f9 Compare April 12, 2024 03:39
@aiwantaozi aiwantaozi requested a review from thxCode April 12, 2024 03:39
gitlawr
gitlawr approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@gitlawr gitlawr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thxCode
thxCode approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@thxCode thxCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thxCode thxCode merged commit 8f9fad2 into seal-io:dev Apr 12, 2024
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gitlawr gitlawr gitlawr approved these changes

@thxCode thxCode thxCode approved these changes

@shanewxy shanewxy Awaiting requested review from shanewxy

@alexcodelf alexcodelf Awaiting requested review from alexcodelf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aiwantaozi @thxCode @gitlawr @alexcodelf