Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does enabling rustls-tls require quinn? #2458

Closed
QuentinPerez opened this issue Oct 27, 2024 · 1 comment
Closed

Why does enabling rustls-tls require quinn? #2458

QuentinPerez opened this issue Oct 27, 2024 · 1 comment
Labels
B-upstream Blocked: upstream. Depends on a dependency to make a change first.

Comments

@QuentinPerez
Copy link

Hi 👋

I noticed that enabling rustls-tls pulls in quinn. Is this expected? I checked reqwest's Cargo.toml but didn't notice anything weird.

Here’s a fresh cargo project for reference.

[package]
name = "hello"
version = "0.1.0"
edition = "2021"

[dependencies]
reqwest = { version = "0.12", default-features = false, features = ["rustls-tls"] }
[[package]]
name = "reqwest"
version = "0.12.8"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "f713147fbe92361e52392c73b8c9e48c04c6625bce969ef54dc901e58e042a7b"
dependencies = [
 "base64",
 "bytes",
 "futures-core",
 "futures-util",
 "http",
 "http-body",
 "http-body-util",
 "hyper",
 "hyper-rustls",
 "hyper-util",
 "ipnet",
 "js-sys",
 "log",
 "mime",
 "once_cell",
 "percent-encoding",
 "pin-project-lite",
 "quinn",                             # <- HERE
 "rustls",
 "rustls-pemfile",
 "rustls-pki-types",
 "serde",
 "serde_json",
 "serde_urlencoded",
 "sync_wrapper",
 "tokio",
 "tokio-rustls",
 "tower-service",
 "url",
 "wasm-bindgen",
 "wasm-bindgen-futures",
 "web-sys",
 "webpki-roots",
 "windows-registry",
]
@seanmonstar
Copy link
Owner

It appears in your Cargo.lock because of a bug: rust-lang/cargo#10801

It doesn't get compiled, though. Previously: #2320 #2318

@seanmonstar seanmonstar closed this as not planned Won't fix, can't repro, duplicate, stale Oct 28, 2024
@seanmonstar seanmonstar added the B-upstream Blocked: upstream. Depends on a dependency to make a change first. label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-upstream Blocked: upstream. Depends on a dependency to make a change first.
Projects
None yet
Development

No branches or pull requests

2 participants