Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New body font-size is way too big #960

Closed
LordSimal opened this issue Nov 19, 2022 · 4 comments
Closed

New body font-size is way too big #960

LordSimal opened this issue Nov 19, 2022 · 4 comments

Comments

@LordSimal
Copy link

LordSimal commented Nov 19, 2022

Q A
php-code-coverage version 9.2.19
PHP version 8.1.10
Driver Xdebug
Xdebug version 3.1.5
Installation Method Composer
Usage Method PHPUnit
PHPUnit version 9.5.26

I just updated to the current latest version, regenerated the Code coverage page and was very confused why the text was so big.

image

Just compare the URL font-size compared to the rest of the text.

This especially is way to wasteful when looking at code lines

image

As you can see here without any zooming I can only see 18 lines of code.

Compared to the old (font-size: 1em) I am able to read 37 lines of code in 1 page.

What was the reason to change the default body font-size to 2em in HERE?

@LordSimal LordSimal changed the title New body font-size is way to big New body font-size is way too big Nov 19, 2022
@gemal
Copy link

gemal commented Nov 19, 2022

yes it's almost unusable now :(

@sebastianbergmann
Copy link
Owner

I am not a frontend developer, sorry. Setting font-size to 2em in aa0971f was motivated by the fact that I wanted the code coverage report to be readable (for me) without having to zoom.

@LordSimal
Copy link
Author

Thanks for the fix and the quick release 😄

Regarding your problem:
Depending on your monitor size, resolution and the UI scaling setting in your OS the text can definitely be very small. I can understand that.
The proper solution to this problem would be to add a body font-size changer element (maybe at the top right) with + and - buttons. If you want I can provide a PR for that.

@sebastianbergmann
Copy link
Owner

If you want I can provide a PR for that.

Yes, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants