File view has wrong colouring for the first column #926
Comments
|
I am sorry, but I do not understand what you want to report. |
|
@hemberger Is this related to #900? Thanks! |
|
I'm happy to take a look and will submit a PR if I can corroborate the issue being reported. |
hemberger
added a commit
to hemberger/php-code-coverage
that referenced
this issue
Aug 19, 2022
Fixes sebastianbergmann#926. The first column in the HTML Report will now be colored by the "Lines" coverage level regardless of view (Directory vs. File) or item type (Directory, File, Class, or Method). While this is somewhat a matter of preference, I think the following arguments support this change: * Prior to sebastianbergmann#900, the first column was always colored the same as the second column. This change restores that pattern since the second column is always "Lines" as of sebastianbergmann#900. * In the File view, the first column for Class and Method items were colored by "Class" and "Method" coverage respectively. This meant that they were only ever 0/1 or 1/1 (red or green). By switching to "Lines" coverage for both, the coloring can be more granular.
|
@sebastianbergmann @hemberger I've updated the issue with screenshots now. |
Thank you! |
sebastianbergmann
pushed a commit
that referenced
this issue
Aug 20, 2022
Fixes #926. The first column in the HTML Report will now be colored by the "Lines" coverage level regardless of view (Directory vs. File) or item type (Directory, File, Class, or Method). While this is somewhat a matter of preference, I think the following arguments support this change: * Prior to #900, the first column was always colored the same as the second column. This change restores that pattern since the second column is always "Lines" as of #900. * In the File view, the first column for Class and Method items were colored by "Class" and "Method" coverage respectively. This meant that they were only ever 0/1 or 1/1 (red or green). By switching to "Lines" coverage for both, the coloring can be more granular.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The file coverage report still has the method names coloured the same as what is now the last column: Classes and Traits. It should be coloured the same as the second column: Lines.
In the example screenshot,
medium_methodshould be coloured yellow, just like "Lines" is. This will make "file view" fully consistent with "directory view" where the first column can be any colour, not just red or green. Note that "Total" and the file name / class name lines are currently inconsistent too, being yellow in the directory view and red in the file view. "Total" can't be both red and yellow at the same time!P.S. The last column (Classes and Traits) possibly shouldn't have any colour for method lines since methods aren't classes or traits. I can make that a separate issue though.
The text was updated successfully, but these errors were encountered: