Remove MockBuilder::setMethods() and MockBuilder::setMethodsExcept()

[sebastianbergmann]

See #3687 (comment) for details.

[lpd-au]

setMethods was replaced by onlyMethods (to mock existing methods) & addMethods (to add new methods), but what replaces setMethodsExcept? (Not mentioned in #3687 (comment)).

[leighman]

Also interested in this ^
You can transform it to onlyMethods of anything you do mock but it's nice to explicitly mock everything except the method under test for futureproofness

[stebogit]

I second the latest comments, supporting the need of setMethodsExcept or an alternative to it.
There are cases where you do want to mock just some of the class methods. In my case I have a class fetching data from the DB and during tests I want to mock those methods reaching the DB and provide the expected/dummy data for the test.

With this comment in mind @sebastianbergmann, I agree in a test suite you consider a class/object as the unit under test, however I'd also argue that in a specific test of that suite you might (often?) test only part(s) of that object, as in maybe one or few methods at a time. Allowing to mock some of the other object's methods allows to perform those tests in isolation.

I wonder if the approach I just mentioned does make sense to you or if you had any thought or suggestions on that.

[olinox14]

I usually mock the whole SUT, except the method I'm testing.

The removal of setMethodExcept is a real regression for us, leaving us stuck with the v9...
Explicitly mocking every involved method with onlyMethods would represent a lot of work, increase the risk of error while mocking, and add an unnecessary verbosity to the tests...

Restoring this functionality would be a real plus.

[classicalguss]

What is the reasoning behind completely removing setMethodExcept and not having any alternative?
There are a lot of old frameworks that have old design approach that you might need to mock except for a few methods.

For example Yii1 have CActiveRecord classes which do a lot of things as soon as you instantiate it. You can mock it fine, but then how can you actually have a real test of the methods that you have designed yourself inside this class?.