-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put composer.lock
under version control
#5578
Comments
This still needs to be backported to the |
Just excellent, thanks <3 ! |
I'm thinking about something to improve the CI and detect discrepancies between How about adding a step that does a |
The build automation I use locally already has it (see https://github.com/sebastianbergmann/phpunit/blob/main/build.xml#L21). And yes, this will be added to GitHub Actions in due course. |
Excellent! All good :) Looking forward for the next tag to provide it in Nix! |
Done :) |
Hi @sebastianbergmann, I hope you don't mind me resurrecting an old issue. I had similar thoughts to your initial response about including I'm curious why you changed your mind on including it in version control, and how you resolved your version of this issue?
|
The |
This is not as simple as proposed in #5576 and also should to be done for the
8.5
,9.6
, and10.5
branches. At this point I do not expect another release from the10.4
branch.The PHAR build process for PHPUnit 8.5 and PHPUnit 9.6 performs
composer require
operations that, of course, modify thecomposer.json
andcomposer.lock
files. The build process needs to be adapter to also roll back the changes tocomposer.lock
. (Thecomposer.lock
that is put into the PHAR for #5577 is the right one.)8.5
9.6
10.5
main
The text was updated successfully, but these errors were encountered: