Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NativeScript 7 Support #8

Closed
asharghi opened this issue Sep 24, 2020 · 9 comments · May be fixed by #14
Closed

NativeScript 7 Support #8

asharghi opened this issue Sep 24, 2020 · 9 comments · May be fixed by #14

Comments

@asharghi
Copy link

Hi @sebestindragos. Thanks for your great work on this plugin. Are you planing on supporting NS7 soon? If you need any help, nStudio is helping plugin authors with it https://nativescript.org/blog/nativescript-7-compatible-plugins/

@sebestindragos
Copy link
Owner

Waiting for #9. I don't have time right now to test for NS7, my internal project is staying on NS6 for the time being.

@asharghi
Copy link
Author

I'm planning to migrate my app to NS7 in a few monts, and can verify then. But may I suggest to publish a major version release of Nathans pr? So you'll have version 1 for NS6 and version 2 for NS7, then if there are any problems with the PR it can later be fixed as patches and minor releases.

@ReeceReynolds
Copy link

Following. Also interested in this being updated to support NS 7.

@sebestindragos
Copy link
Owner

Hi guys, just published [email protected] with support for NS7. Let me know if it works for you.
And a huge thanks to @NathanWalker , it was his PR that added support for NS7.

@liuy97
Copy link

liuy97 commented Jan 15, 2021

I got an uncaught exception using [email protected] in iOS.

CoreFoundation) *** Terminating app due to uncaught exception 'NativeScript encountered a fatal error: Uncaught ReferenceError: NativeClass is not defined at ../node_modules/nativescript-plugin-universal-links/plugin-universal-links.js(file: node_modules/nativescript-plugin-universal-links/plugin-universal-links.ios.js:7:0)

@NathanWalker
Copy link
Contributor

@sebestindragos You most likely forgot to ts-patch install in your src before building. If can do that and republish a patch would fix that ^ - always check your compiled .js files to make sure the transformations took place as the compiled .js should have no mention of NativeClass anywhere.

@NathanWalker
Copy link
Contributor

NathanWalker commented Jan 15, 2021

This is another reason we highly recommend the plugin workspaces as it handles things like that all seamlessly.:
https://github.com/NativeScript/plugin-seed
https://nativescript.org/blog/announcing-plugin-workspaces/

@tralves
Copy link

tralves commented Feb 17, 2021

While this package is not re-published, you can use my fork in package.json like this:

"nativescript-plugin-universal-links": "https://github.com/tralves/nativescript-plugin-universal-links/raw/master/dist/nativescript-plugin-universal-links.tar.gz",

@sebestindragos
Copy link
Owner

This project is no longer maintained in this repo, it has been taken over by the NS Community
https://github.com/nativescript-community/universal-links

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants