LLVM 13 #112

jacky860226 · 2021-08-20T13:45:17Z

LLVM 12
LLVM 13
Fix CreateLoad warning because it is DEPRECATED for some kinds. (https://llvm.org/doxygen/classllvm_1_1IRBuilderBase.html)
Add Wno-redundant-move ? (ref : https://reviews.llvm.org/D70963)

codecov · 2021-11-23T18:12:06Z

Codecov Report

Merging #112 (b2bc554) into master (dd539e0) will increase coverage by 0.01%.
The diff coverage is 75.75%.

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
+ Coverage   66.47%   66.48%   +0.01%     
==========================================
  Files          98       98              
  Lines       13679    13743      +64     
  Branches     2041     2047       +6     
==========================================
+ Hits         9093     9137      +44     
- Misses       3567     3585      +18     
- Partials     1019     1021       +2

Impacted Files	Coverage Δ
include/soll/AST/ASTContext.h	`100.00% <ø> (ø)`
include/soll/Basic/FileManager.h	`100.00% <ø> (ø)`
include/soll/Basic/IdentifierTable.h	`96.15% <ø> (ø)`
lib/CodeGen/CodeGenModule.h	`96.55% <ø> (ø)`
lib/Frontend/ASTConsumers/ASTPrinter.cpp	`11.22% <ø> (ø)`
lib/Parse/ParseYul.cpp	`88.88% <ø> (ø)`
lib/Sema/SemaExprAsm.cpp	`91.12% <28.57%> (-0.78%)`	⬇️
lib/CodeGen/BackendUtil.cpp	`53.50% <54.54%> (ø)`
lib/CodeGen/CodeGenModule.cpp	`64.70% <66.19%> (-0.02%)`	⬇️
lib/CodeGen/CodeGenAction.cpp	`74.64% <66.66%> (+0.70%)`	⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd539e0...b2bc554. Read the comment docs.

lgtm-com · 2021-11-23T18:20:34Z

This pull request introduces 1 alert when merging c4413c3 into ab2b60d - view on LGTM.com

new alerts:

1 for FIXME comment

lgtm-com · 2021-11-23T18:55:00Z

This pull request introduces 1 alert when merging 833e078 into ab2b60d - view on LGTM.com

new alerts:

1 for FIXME comment

lgtm-com · 2021-11-24T14:57:40Z

This pull request introduces 1 alert when merging b1ca5cf into ab2b60d - view on LGTM.com

new alerts:

1 for FIXME comment

lgtm-com · 2021-11-30T17:35:49Z

This pull request introduces 1 alert when merging 1f1b6b3 into ab2b60d - view on LGTM.com

new alerts:

1 for FIXME comment

lgtm-com · 2021-12-01T16:13:03Z

This pull request introduces 1 alert when merging 16a788f into ab2b60d - view on LGTM.com

new alerts:

1 for FIXME comment

lgtm-com · 2021-12-01T16:36:33Z

This pull request introduces 1 alert when merging 1be0ff1 into ab2b60d - view on LGTM.com

new alerts:

1 for FIXME comment

lgtm-com · 2021-12-02T05:51:45Z

This pull request introduces 1 alert when merging a31d805 into ab2b60d - view on LGTM.com

new alerts:

1 for FIXME comment

ibmibmibm · 2021-12-02T08:52:03Z

include/soll/AST/Decl.h

@@ -29,8 +29,7 @@ class Decl {
  friend class ASTReader;

 protected:
-  Decl(SourceRange L,
-       llvm::StringRef Name = llvm::StringRef::withNullAsEmpty(nullptr),
+  Decl(SourceRange L, llvm::StringRef Name = llvm::StringRef(""),


Decl(SourceRange L, llvm::StringRef Name = {},

ibmibmibm · 2021-12-02T08:53:49Z

lib/CodeGen/ABICodec.cpp

@@ -49,7 +49,8 @@ llvm::Value *AbiEmitter::emitEncodeTuple(
    std::tie(Value, IsStateVariable) = Values[I];
    if (Value->getType()->isDynamic()) {
      DynamicPos.emplace_back(Int8Ptr, I);
-      Int8Ptr = Builder.CreateInBoundsGEP(Int8Ptr, {Builder.getIntN(32, 32)});
+      Int8Ptr = Builder.CreateInBoundsGEP(Builder.getInt8Ty(), Int8Ptr,


CGM.Int8Ty

ibmibmibm · 2021-12-02T08:53:55Z

lib/CodeGen/ABICodec.cpp

@@ -96,7 +97,7 @@ AbiEmitter::getDecode(llvm::Value *Int8Ptr, const Type *Ty) {
                           Builder.getIntN(32, 32)),
        Builder.getIntN(32, 32));
    llvm::Value *NextInt8Ptr =
-        Builder.CreateInBoundsGEP(Int8Ptr, {EncodeLength});
+        Builder.CreateInBoundsGEP(Builder.getInt8Ty(), Int8Ptr, {EncodeLength});


CGM.Int8Ty

ibmibmibm · 2021-12-02T08:54:04Z

lib/CodeGen/ABICodec.cpp

-        Builder.CreateInBoundsGEP(Int8Ptr, {Builder.getInt32(32)});
+    llvm::Value *Val = Builder.CreateLoad(ValueTy, ValPtr);
+    llvm::Value *NextInt8Ptr = Builder.CreateInBoundsGEP(
+        Builder.getInt8Ty(), Int8Ptr, {Builder.getInt32(32)});


CGM.Int8Ty

ibmibmibm · 2021-12-02T08:54:13Z

lib/CodeGen/ABICodec.cpp

    Val = CGM.getEndianlessValue(Val);
    Val = Builder.CreateZExtOrTrunc(Val, ValueTy);
    llvm::Value *NextInt8Ptr = Builder.CreateInBoundsGEP(
-        Int8Ptr, {Builder.getInt32(ValueTy->getIntegerBitWidth() / 8)});
+        Builder.getInt8Ty(), Int8Ptr,


CGM.Int8Ty

ibmibmibm · 2021-12-02T09:03:09Z

lib/CodeGen/CGExpr.cpp

-  llvm::Value *Ptr =
-      Builder.CreateInBoundsGEP(CGM.getHeapBase(), {Pos}, "heap.cptr");
+  llvm::Value *Ptr = Builder.CreateInBoundsGEP(
+      CGM.getHeapBase()->getType()->getPointerElementType(), CGM.getHeapBase(),


CGM.Int8Ty

ibmibmibm · 2021-12-02T09:07:23Z

lib/CodeGen/CGExpr.cpp

@@ -1015,13 +1025,15 @@ void CodeGenFunction::emitAsmSetImmutable(const CallExpr *CE) {
        llvm::Value *Offset = emitExpr(Arguments[0])->load(Builder, CGM);
        llvm::Value *TableOffset = Builder.getInt(Map.lookup(StringRefName));
        llvm::Value *ImmutableCPtr = Builder.CreateInBoundsGEP(
+            CGM.getImmutableBase()->getType()->getPointerElementType(),


CGM.Int256Ty

ibmibmibm · 2021-12-02T09:07:38Z

lib/CodeGen/CGExpr.cpp

-        llvm::Value *HeapCPtr =
-            Builder.CreateInBoundsGEP(CGM.getHeapBase(), {Offset}, "heap.cptr");
+        llvm::Value *HeapCPtr = Builder.CreateInBoundsGEP(
+            CGM.getHeapBase()->getType()->getPointerElementType(),


CGM.Int8Ty

ibmibmibm · 2021-12-02T09:07:46Z

lib/CodeGen/CGExpr.cpp

-        llvm::Value *HeapCPtr =
-            Builder.CreateInBoundsGEP(CGM.getHeapBase(), {Offset}, "heap.cptr");
+        llvm::Value *HeapCPtr = Builder.CreateInBoundsGEP(
+            CGM.getHeapBase()->getType()->getPointerElementType(),


CGM.Int8Ty

ibmibmibm · 2021-12-02T09:07:54Z

lib/CodeGen/CGExpr.cpp

@@ -1044,13 +1056,17 @@ llvm::Value *CodeGenFunction::emitAsmLoadImmutable(const CallExpr *CE) {
      if (Map.find(StringRefName) != Map.end()) {
        llvm::Value *TableOffset = Builder.getInt(Map.lookup(StringRefName));
        llvm::Value *ImmutableCPtr = Builder.CreateInBoundsGEP(
+            CGM.getImmutableBase()->getType()->getPointerElementType(),


CGM.Int256Ty

lgtm-com · 2021-12-12T08:42:13Z

This pull request introduces 1 alert when merging f0c50ea into ab2b60d - view on LGTM.com

new alerts:

1 for FIXME comment

lgtm-com · 2021-12-23T05:51:25Z

This pull request introduces 1 alert when merging b2bc554 into dd539e0 - view on LGTM.com

new alerts:

1 for FIXME comment

jacky860226 requested a review from hydai August 20, 2021 13:45

LFsWang force-pushed the yul_metadata branch 3 times, most recently from b131520 to c4413c3 Compare November 23, 2021 18:05

LFsWang changed the title ~~LLVM 12~~ [WIP] LLVM 13 Nov 23, 2021

LFsWang force-pushed the yul_metadata branch from 833e078 to b1ca5cf Compare November 24, 2021 14:44

LFsWang changed the title ~~[WIP] LLVM 13~~ LLVM 13 Nov 24, 2021

LFsWang force-pushed the yul_metadata branch from 1f1b6b3 to 16a788f Compare December 1, 2021 16:01

LFsWang force-pushed the yul_metadata branch 2 times, most recently from 82fe33f to 1be0ff1 Compare December 1, 2021 16:23

LFsWang force-pushed the yul_metadata branch from 1be0ff1 to a31d805 Compare December 2, 2021 05:39

ibmibmibm requested changes Dec 2, 2021

View reviewed changes

LFsWang force-pushed the yul_metadata branch from a31d805 to f0c50ea Compare December 12, 2021 08:29

hydai requested a review from ibmibmibm December 16, 2021 06:03

Jinkela and others added 5 commits December 23, 2021 13:33

[CodeGen] Cancel attaching '.metadata' to wasm bytecode.

6ced662

[CodeGen] implement '.metadata' for Yul.

0d7c0f7

[Misc] update llvm version to 12

82f8033

[Misc] update llvm version to 13

109595c

[Misc] Remove deprecated ABI

b2bc554

LFsWang force-pushed the yul_metadata branch from f0c50ea to b2bc554 Compare December 23, 2021 05:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LLVM 13 #112

LLVM 13 #112

jacky860226 commented Aug 20, 2021 •

edited by LFsWang

Loading

codecov bot commented Nov 23, 2021 •

edited

Loading

lgtm-com bot commented Nov 23, 2021

lgtm-com bot commented Nov 23, 2021

lgtm-com bot commented Nov 24, 2021

lgtm-com bot commented Nov 30, 2021

lgtm-com bot commented Dec 1, 2021

lgtm-com bot commented Dec 1, 2021

lgtm-com bot commented Dec 2, 2021

ibmibmibm Dec 2, 2021

ibmibmibm Dec 2, 2021

ibmibmibm Dec 2, 2021

ibmibmibm Dec 2, 2021

ibmibmibm Dec 2, 2021

ibmibmibm Dec 2, 2021

ibmibmibm Dec 2, 2021

ibmibmibm Dec 2, 2021

ibmibmibm Dec 2, 2021

ibmibmibm Dec 2, 2021

lgtm-com bot commented Dec 12, 2021

lgtm-com bot commented Dec 23, 2021

LLVM 13 #112

Are you sure you want to change the base?

LLVM 13 #112

Conversation

jacky860226 commented Aug 20, 2021 • edited by LFsWang Loading

codecov bot commented Nov 23, 2021 • edited Loading

Codecov Report

lgtm-com bot commented Nov 23, 2021

lgtm-com bot commented Nov 23, 2021

lgtm-com bot commented Nov 24, 2021

lgtm-com bot commented Nov 30, 2021

lgtm-com bot commented Dec 1, 2021

lgtm-com bot commented Dec 1, 2021

lgtm-com bot commented Dec 2, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lgtm-com bot commented Dec 12, 2021

lgtm-com bot commented Dec 23, 2021

jacky860226 commented Aug 20, 2021 •

edited by LFsWang

Loading

codecov bot commented Nov 23, 2021 •

edited

Loading