Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Use hatchling (or get rid of setuptools_scm anyway) #483

Closed
jku opened this issue Dec 14, 2022 · 1 comment · Fixed by #484
Closed

build: Use hatchling (or get rid of setuptools_scm anyway) #483

jku opened this issue Dec 14, 2022 · 1 comment · Fixed by #484

Comments

@jku
Copy link
Collaborator

jku commented Dec 14, 2022

setuptools_scm tries to be way more smart than it should and breaks pip install git+https://github.com/jku/securesystemslib.git which is useful for testing PR branches in downstream projects. Specifically it imagines the git tag 'debian/0.16.0-1' is a version number and asserts because it doesn't quite work.

I suggest we get rid of setuptools_scm...

  • we currently use it for automated version setting from git describe (and I sort of like that -- getting development version numbers for free is nice)
  • hatchling has VCS support as well, so could just switch to hatchling (since I think that was the plan anyway) and hope the VCS support is better
  • if VCS support is found to be a bad idea, hatchcling can read the version from __init__.py
@jku
Copy link
Collaborator Author

jku commented Dec 14, 2022

lol hatch-vcs actually uses setuptools-scm internally so we get the same bug 😂

So we don't get nice toys then: let's remove VCS integration and add version number into __init__py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant