Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signer: test AWS signer with LocalStack #612

Closed
lukpueh opened this issue Aug 1, 2023 · 4 comments · Fixed by #777
Closed

signer: test AWS signer with LocalStack #612

lukpueh opened this issue Aug 1, 2023 · 4 comments · Fixed by #777
Assignees
Labels
contribfest Issues for KubeCon EU contribfest tests Issues related to testing

Comments

@lukpueh
Copy link
Member

lukpueh commented Aug 1, 2023

#609 adds an AWS signer including a test case (check_aws_signer.py), which is currently not part of our CI. @kairoaraujo suggested to try out LocalStack.

@lukpueh
Copy link
Member Author

lukpueh commented Aug 1, 2023

cc @ianhundere

@lukpueh lukpueh mentioned this issue Aug 2, 2023
3 tasks
@lukpueh
Copy link
Member Author

lukpueh commented Mar 14, 2024

Can be copied from repository-service-tuf/repository-service-tuf-worker@c4b26c0

@lukpueh lukpueh added contribfest Issues for KubeCon EU contribfest tests Issues related to testing labels Mar 14, 2024
@kairoaraujo
Copy link

I will take this one

lukpueh added a commit to lukpueh/securesystemslib that referenced this issue Apr 11, 2024
Add test setup to test AWSSigner locally or on GitHub CI using
localstack.

**Change details**

* Add independent tox environment to init/cleanup localstack, configure
  ambient AWS KMS credentials, create test keys, and run the test.

* Adds aws requirements file with pinned runtime requirements to trigger
  tox run via Dependabot. Note: test requirements are not included, but
  defined directly in tox.ini without pinning (we don't really need to
  trigger of those update).

* Adds shell script to generate test keys for all supported schemes in
  tox setup.

* Update AWSSigner tests to match localstack setup. The previous setup
  looked like it needed manual intervention in order to run. The new
  tests runs the full Signer API flow  -- import (with and without passed
  scheme), load, sign, verify (pass and fail) --  automatically and for
  each scheme supported by AWSSigner.

* Adds independent GitHub Action workflow to run tox aws test

closes secure-systems-lab#612

Signed-off-by: Lukas Puehringer <[email protected]>
@lukpueh
Copy link
Member Author

lukpueh commented Apr 11, 2024

I will take this one

I took it ... after coordinating with Kairo :)

👉 #777

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribfest Issues for KubeCon EU contribfest tests Issues related to testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants