Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for leap day birthdays in non-leap years #1

Open
seeeeew opened this issue Jan 8, 2021 · 2 comments
Open

support for leap day birthdays in non-leap years #1

seeeeew opened this issue Jan 8, 2021 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@seeeeew
Copy link
Owner

seeeeew commented Jan 8, 2021

Currently leap day birthdays in non-leap years work as expected in bday list and bday next, but the bot won't send out alerts for them, since the date is simply skipped. This behavior isn't wrong, but also not optimal.

@seeeeew seeeeew added enhancement New feature or request help wanted Extra attention is needed labels Jan 8, 2021
@seeeeew
Copy link
Owner Author

seeeeew commented Feb 7, 2021

The best solution is probably to ask the user if they want to get their birthday message on the 28th or the 1st. Just need to decide how to ask them and how to store the information.

@seeeeew
Copy link
Owner Author

seeeeew commented Sep 30, 2022

  • New column leap_adj (-1/0/+1, default 0) in table birthdays.
  • New hidden command <prefix>bday leap <value>:
    • <prefix>bday leap before – send birthday message on 28 February in common years
    • <prefix>bday leap after – send birthday message on 1 March in common years
    • <prefix>bday leap reset – don't send birthday message in common years (default, at least for now)
  • Command won't appear in the help, instead the bot will tell users about it when they set their birthday to 29 February.
  • Bot will show the actual birthday in lists, but internally work with the adjusted birthday.

@seeeeew seeeeew added this to the 1.1.0 milestone Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant