Skip to content
This repository has been archived by the owner on Feb 28, 2018. It is now read-only.

doesn't work with server side prerendering #36

Closed
EXC-BAD-ACCESS opened this issue Apr 24, 2016 · 4 comments
Closed

doesn't work with server side prerendering #36

EXC-BAD-ACCESS opened this issue Apr 24, 2016 · 4 comments

Comments

@EXC-BAD-ACCESS
Copy link
Contributor

this line references "navigator" which doesn't exist on the server, it could be changed to something like: if (typeof navigator !== 'undefined' && !/Firefox/.test(navigator.userAgent)) return; to support server side rendering

@seethroughdev
Copy link
Owner

makes sense. thanks @AppSorcery want to send a PR?

@EXC-BAD-ACCESS
Copy link
Contributor Author

#37

@EXC-BAD-ACCESS
Copy link
Contributor Author

when i tested my previous pull request i must have accidentally been running webpack's hot-dev-server which doesn't quite work the same a a deployed version of a prerendered app...

when i went to deploy i found it still wasn't working with prerendering because of the getDOMNode() call in the same timeout function. #39 fixes it (and was tested in a real deployment ;)

@seethroughdev
Copy link
Owner

Hi @AppSorcery , can you take a look at the latest and make sure it solves the issue? Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants