-
Notifications
You must be signed in to change notification settings - Fork 224
Getting a strncpy warning during build #104
Comments
Are you installing on Windows? |
Shoot...sorry I forgot to add that. The machine is a windows 10 64-bit. I also have the latest version of Go installed. I also have the latest version of MinGW64 installed. Installation of Go and MinGW64 has been tested and verified. Path variable is pointing to all of the relevant bin locations. |
We don't use a lot of Windows at Segment, so it'll be tough for us to repro and track this down, but I'll see what I can do. That looks like a warning, not an error; I'm surprised that'd break the whole build? |
Once it hits the error it terminates and doe not complete creating the bin files so the aws-okta.exe is never created. |
I getting this too. |
@devonbleak I know you folks use Windows: are you getting this error as well? Any advice? |
@nickatsegment Can confirm I had one report of this with mingw64 on Win10. I use win-builds gcc and haven't run into it myself. |
Submitted #118 that documents the existence of an issue with mingw-w64 gcc |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I think this should still be open as the warning is still present: Windows Version
GCC Version
Warning
|
@dave-tucker What's the impact for you? Is it just annoying? Or does it prevent a build? Seems like it's got the potential to be a security bug. Frankly my ability to dive into a HID library written in C for Windows is pretty limited. I wouldn't expect this to get fixed any time soon. |
It's more concerning that annoying - especially as it's used to interact with USB security devices.
Led to finding that |
Ha, looks like our very own @alberts has been here before marshallbrekka/go-u2fhost#3 (comment). Seems like these libs are all a little under-maintained. Seems like we should fork. |
this error still happens when trying to execute |
Looks like marshallbrekka/go-u2fhost#4 got fixed by marshallbrekka/go-u2fhost#5, so maybe this error goes away. If a Windows user can get a build using this updated version of go-u2fhost tested, I'd be willing to accept a PR. |
Upon issuing the go get github.com/segmentio/aws-okta command the software starts downloading and installing the package. The installation errors out with the following error message:
This error prevents aws-okta from being completely installed.
The text was updated successfully, but these errors were encountered: