Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsafe is broken #1157

Closed
mhmtszr opened this issue Jul 7, 2023 · 0 comments · Fixed by #1158
Closed

Unsafe is broken #1157

mhmtszr opened this issue Jul 7, 2023 · 0 comments · Fixed by #1158
Labels
bug

Comments

@mhmtszr
Copy link
Contributor

mhmtszr commented Jul 7, 2023

Describe the bug

This development broke unsafe usage,

../../go/pkg/mod/github.com/segmentio/[email protected]/protocol/decode.go:90:4: v.setFloat64 undefined (type value has no field or method setFloat64)
../../go/pkg/mod/github.com/segmentio/[email protected]/protocol/encode.go:134:19: v.float64 undefined (type value has no field or method float64)

We also need to add these functions to reflect_unsafe.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add float64 operations to reflect unsafe mhmtszr/kafka-go
1 participant
@mhmtszr