Add a removeCurrentItems
parameter to clearOptions()
to allow for either intended behavior
#2147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clearOptions(false, false)
)clearOptions()
now, by default, removes currently-selected items in addition to deselecting them,as it did prior to selectize v0.12.5.
removeCurrentItems
, defaulttrue
.removeCurrentItems
is setfalse
, the function will instead leave currently-selected itemsavailable and selected, as was the case from selectize v0.12.5, until v0.13.1 introduced
#2146 (which this change fixes).
silent
also has a (backwards-compatible) default value offalse
now.clearOptions(silent = false, removeCurrentItems = true)
I don't feel very strongly about the new parameter being default
true
, as long as whatever its default value is, is correctly and comprehensively documented. You could make the argument either way.