Apparently the Safari tech preview has a different browser name

Who knew? Also, we need to find how to set capabilities in a w3c compliant way.
SeleniumHQ · Jul 13, 2018 · 0efc0be · 0efc0be
1 parent 4c93795
commit 0efc0be
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/java/client/src/org/openqa/selenium/safari/SafariOptions.java b/java/client/src/org/openqa/selenium/safari/SafariOptions.java
@@ -17,6 +17,8 @@
 
 package org.openqa.selenium.safari;
 
+import static org.openqa.selenium.remote.CapabilityType.BROWSER_NAME;
+
 import com.google.common.collect.ImmutableSortedMap;
 
 import org.openqa.selenium.Capabilities;
@@ -60,7 +62,7 @@ private interface Option {
 
   public SafariOptions() {
     setUseTechnologyPreview(false);
-    setCapability(CapabilityType.BROWSER_NAME, "safari");
+    setCapability(BROWSER_NAME, "safari");
   }
 
   public SafariOptions(Capabilities source) {
@@ -118,6 +120,7 @@ public static SafariOptions fromCapabilities(Capabilities capabilities)
    */
   public SafariOptions setUseTechnologyPreview(boolean useTechnologyPreview) {
     options.put(Option.TECHNOLOGY_PREVIEW, useTechnologyPreview);
+    setCapability(BROWSER_NAME, useTechnologyPreview ? "Safari Technology Preview" : "safari");
     return this;
   }
 

diff --git a/java/client/test/org/openqa/selenium/safari/SafariOptionsTest.java b/java/client/test/org/openqa/selenium/safari/SafariOptionsTest.java
@@ -44,4 +44,16 @@ public void canConstructFromCapabilities() {
     assertTrue(options.getUseTechnologyPreview());
   }
 
+  @Test
+  public void settingTechnologyPreviewModeAlsoChangesBrowserName() {
+    SafariOptions options = new SafariOptions();
+    assertEquals("safari", options.getBrowserName());
+
+    options.setUseTechnologyPreview(true);
+    assertEquals("Safari Technology Preview", options.getBrowserName());
+
+    options.setUseTechnologyPreview(false);
+    assertEquals("safari", options.getBrowserName());
+  }
 }
+