[dotnet] Run Edge tests on RBE

SeleniumHQ · Mar 15, 2024 · 1aa091e · 1aa091e
1 parent 4b584ef
commit 1aa091e
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/.skipped-tests b/.skipped-tests
@@ -1,5 +1,6 @@
 -//dotnet/test/common:DevTools/DevToolsNetworkTest-chrome
 -//dotnet/test/common:Interactions/BasicMouseInterfaceTest-chrome
+-//dotnet/test/common:Interactions/BasicMouseInterfaceTest-edge
 -//dotnet/test/common:Interactions/BasicMouseInterfaceTest-firefox
 -//dotnet/test/common:JavascriptEnabledBrowserTest-chrome
 -//dotnet/test/common:NetworkInterceptionTests-chrome
@@ -29,6 +30,7 @@
 -//java/test/org/openqa/selenium/remote:RemoteWebDriverBuilderTest
 -//java/test/org/openqa/selenium/remote:RemoteWebDriverScreenshotTest-remote
 -//javascript/atoms:test-chrome
+-//javascript/atoms:test-edge
 -//javascript/atoms:test-firefox-beta
 -//javascript/atoms:test-firefox-dev
 -//py:common-chrome-test/selenium/webdriver/common/virtual_authenticator_tests.py

diff --git a/dotnet/private/dotnet_nunit_test_suite.bzl b/dotnet/private/dotnet_nunit_test_suite.bzl
@@ -32,6 +32,10 @@ _BROWSERS = {
         "args": [
             "--params=ActiveDriverConfig=Edge",
         ] + select({
+            "@selenium//common:use_pinned_linux_edge": [
+                "--params=DriverServiceLocation=$(location @linux_edgedriver//:msedgedriver)",
+                "--params=BrowserLocation=$(location @linux_edge//:opt/microsoft/msedge/microsoft-edge)",
+            ],
             "@selenium//common:use_pinned_macos_edge": [
                 "--params=DriverServiceLocation=$(location @mac_edgedriver//:msedgedriver)",
                 "\"--params=BrowserLocation=$(location @mac_edge//:Edge.app)/Contents/MacOS/Microsoft Edge\"",
@@ -42,7 +46,7 @@ _BROWSERS = {
             ],
         }),
         "data": edge_data,
-        "tags": ["skip-remote"],
+        "tags": [],
     },
     "firefox": {
         "args": [

diff --git a/dotnet/test/common/Environment/DriverFactory.cs b/dotnet/test/common/Environment/DriverFactory.cs
@@ -87,6 +87,10 @@ public IWebDriver CreateDriverWithOptions(Type driverType, DriverOptions driverO
             {
                 browser = Browser.Edge;
                 options = GetDriverOptions<EdgeOptions>(driverType, driverOptions);
+
+                var edgeOptions = (EdgeOptions)options;
+                edgeOptions.AddArguments("--no-sandbox", "--disable-dev-shm-usage");
+
                 service = CreateService<EdgeDriverService>();
                 if (!string.IsNullOrEmpty(this.browserBinaryLocation))
                 {