[java] Skipping FederatedCredentialManagementTest tests

SeleniumHQ · Mar 25, 2024 · 5be82f7 · 5be82f7
1 parent 2031018
commit 5be82f7
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/.github/workflows/ci-java.yml b/.github/workflows/ci-java.yml
@@ -22,7 +22,6 @@ jobs:
         bazel test //java/test/org/openqa/selenium/chrome:ChromeDriverFunctionalTest `
             //java/test/org/openqa/selenium/federatedcredentialmanagement:FederatedCredentialManagementTest `
             //java/test/org/openqa/selenium/firefox:FirefoxDriverBuilderTest `
-            //java/test/org/openqa/selenium/grid/gridui:OverallGridTest `
             //java/test/org/openqa/selenium/grid/router:RemoteWebDriverDownloadTest `
             //java/test/org/openqa/selenium/remote:RemoteWebDriverBuilderTest `
             //java/test/org/openqa/selenium/grid/router:RemoteWebDriverDownloadTest
@@ -44,7 +43,6 @@ jobs:
         bazel test //java/test/org/openqa/selenium/chrome:ChromeDriverFunctionalTest-remote \
             //java/test/org/openqa/selenium/federatedcredentialmanagement:FederatedCredentialManagementTest \
             //java/test/org/openqa/selenium/firefox:FirefoxDriverBuilderTest \
-            //java/test/org/openqa/selenium/grid/gridui:OverallGridTest \
             //java/test/org/openqa/selenium/grid/router:RemoteWebDriverDownloadTest \
             //java/test/org/openqa/selenium/remote:RemoteWebDriverBuilderTest \
             //java/test/org/openqa/selenium/grid/router:RemoteWebDriverDownloadTest

diff --git a/.../org/openqa/selenium/federatedcredentialmanagement/FederatedCredentialManagementTest.java b/.../org/openqa/selenium/federatedcredentialmanagement/FederatedCredentialManagementTest.java
@@ -23,6 +23,7 @@
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertNull;
 import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.openqa.selenium.testing.drivers.Browser.CHROME;
 
 import java.net.MalformedURLException;
 import java.net.URL;
@@ -35,7 +36,7 @@
 import org.openqa.selenium.chrome.ChromeOptions;
 import org.openqa.selenium.support.ui.WebDriverWait;
 import org.openqa.selenium.testing.JupiterTestBase;
-import org.openqa.selenium.testing.drivers.Browser;
+import org.openqa.selenium.testing.NotYetImplemented;
 
 class FederatedCredentialManagementTest extends JupiterTestBase {
 
@@ -44,7 +45,7 @@ class FederatedCredentialManagementTest extends JupiterTestBase {
 
   @BeforeEach
   public void setup() {
-    ChromeOptions options = (ChromeOptions) Browser.CHROME.getCapabilities();
+    ChromeOptions options = (ChromeOptions) CHROME.getCapabilities();
     // options.setAcceptInsecureCerts(true);
     options.addArguments(
         String.format("host-resolver-rules=MAP localhost:443 localhost:%d", getSecurePort()));
@@ -80,6 +81,9 @@ private int getSecurePort() {
   }
 
   @Test
+  @NotYetImplemented(
+      value = CHROME,
+      reason = "https://github.com/SeleniumHQ/selenium/pull/12096#issuecomment-2017760822")
   void testDismissDialog() {
     fedcmDriver.setDelayEnabled(false);
     assertNull(fedcmDriver.getFederatedCredentialManagementDialog());
@@ -112,6 +116,9 @@ void testDismissDialog() {
   }
 
   @Test
+  @NotYetImplemented(
+      value = CHROME,
+      reason = "https://github.com/SeleniumHQ/selenium/pull/12096#issuecomment-2017760822")
   void testSelectAccount() {
     fedcmDriver.setDelayEnabled(false);
     assertNull(fedcmDriver.getFederatedCredentialManagementDialog());