[java] Enabling a few BiDi tests for Firefox

SeleniumHQ · Mar 25, 2024 · 87fe8b7 · 87fe8b7
1 parent f437fdd
commit 87fe8b7
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 24 deletions.
diff --git a/java/test/org/openqa/selenium/bidi/browser/BrowserCommandsTest.java b/java/test/org/openqa/selenium/bidi/browser/BrowserCommandsTest.java
@@ -20,7 +20,6 @@
 import static org.assertj.core.api.AssertionsForClassTypes.assertThat;
 import static org.openqa.selenium.testing.Safely.safelyCall;
 import static org.openqa.selenium.testing.drivers.Browser.EDGE;
-import static org.openqa.selenium.testing.drivers.Browser.FIREFOX;
 import static org.openqa.selenium.testing.drivers.Browser.IE;
 import static org.openqa.selenium.testing.drivers.Browser.SAFARI;
 
@@ -50,7 +49,6 @@ public void setUp() {
   @NotYetImplemented(SAFARI)
   @NotYetImplemented(IE)
   @NotYetImplemented(EDGE)
-  @NotYetImplemented(FIREFOX)
   void canCreateAUserContext() {
     String userContext = browser.createUserContext();
 
@@ -63,7 +61,6 @@ void canCreateAUserContext() {
   @NotYetImplemented(SAFARI)
   @NotYetImplemented(IE)
   @NotYetImplemented(EDGE)
-  @NotYetImplemented(FIREFOX)
   void canGetUserContexts() {
     String userContext1 = browser.createUserContext();
     String userContext2 = browser.createUserContext();
@@ -79,7 +76,6 @@ void canGetUserContexts() {
   @NotYetImplemented(SAFARI)
   @NotYetImplemented(IE)
   @NotYetImplemented(EDGE)
-  @NotYetImplemented(FIREFOX)
   void canRemoveUserContext() {
     String userContext1 = browser.createUserContext();
     String userContext2 = browser.createUserContext();

diff --git a/java/test/org/openqa/selenium/bidi/network/AddInterceptParametersTest.java b/java/test/org/openqa/selenium/bidi/network/AddInterceptParametersTest.java
@@ -20,7 +20,6 @@
 import static org.assertj.core.api.AssertionsForClassTypes.assertThat;
 import static org.openqa.selenium.testing.Safely.safelyCall;
 import static org.openqa.selenium.testing.drivers.Browser.EDGE;
-import static org.openqa.selenium.testing.drivers.Browser.FIREFOX;
 import static org.openqa.selenium.testing.drivers.Browser.IE;
 import static org.openqa.selenium.testing.drivers.Browser.SAFARI;
 
@@ -48,7 +47,6 @@ public void setUp() {
   @NotYetImplemented(SAFARI)
   @NotYetImplemented(IE)
   @NotYetImplemented(EDGE)
-  @NotYetImplemented(FIREFOX)
   void canAddInterceptPhase() {
     try (Network network = new Network(driver)) {
       String intercept =
@@ -61,7 +59,6 @@ void canAddInterceptPhase() {
   @NotYetImplemented(SAFARI)
   @NotYetImplemented(IE)
   @NotYetImplemented(EDGE)
-  @NotYetImplemented(FIREFOX)
   void canAddInterceptPhases() {
     try (Network network = new Network(driver)) {
       String intercept =
@@ -76,7 +73,6 @@ void canAddInterceptPhases() {
   @NotYetImplemented(SAFARI)
   @NotYetImplemented(IE)
   @NotYetImplemented(EDGE)
-  @NotYetImplemented(FIREFOX)
   void canAddStringUrlPattern() {
     try (Network network = new Network(driver)) {
       String intercept =
@@ -91,7 +87,6 @@ void canAddStringUrlPattern() {
   @NotYetImplemented(SAFARI)
   @NotYetImplemented(IE)
   @NotYetImplemented(EDGE)
-  @NotYetImplemented(FIREFOX)
   void canAddStringUrlPatterns() {
     try (Network network = new Network(driver)) {
       String intercept =
@@ -109,7 +104,6 @@ void canAddStringUrlPatterns() {
   @NotYetImplemented(SAFARI)
   @NotYetImplemented(IE)
   @NotYetImplemented(EDGE)
-  @NotYetImplemented(FIREFOX)
   void canAddUrlPattern() {
     try (Network network = new Network(driver)) {
       UrlPattern pattern =
@@ -131,7 +125,6 @@ void canAddUrlPattern() {
   @NotYetImplemented(SAFARI)
   @NotYetImplemented(IE)
   @NotYetImplemented(EDGE)
-  @NotYetImplemented(FIREFOX)
   void canAddUrlPatterns() {
     try (Network network = new Network(driver)) {
       UrlPattern pattern1 =

diff --git a/java/test/org/openqa/selenium/bidi/network/NetworkCommandsTest.java b/java/test/org/openqa/selenium/bidi/network/NetworkCommandsTest.java
@@ -59,7 +59,6 @@ public void setUp() {
   @NotYetImplemented(SAFARI)
   @NotYetImplemented(IE)
   @NotYetImplemented(EDGE)
-  @NotYetImplemented(FIREFOX)
   void canAddIntercept() {
     try (Network network = new Network(driver)) {
       String intercept =
@@ -72,7 +71,6 @@ void canAddIntercept() {
   @NotYetImplemented(SAFARI)
   @NotYetImplemented(IE)
   @NotYetImplemented(EDGE)
-  @NotYetImplemented(FIREFOX)
   void canContinueRequest() throws InterruptedException {
     try (Network network = new Network(driver)) {
       String intercept =
@@ -107,7 +105,6 @@ void canContinueRequest() throws InterruptedException {
   @NotYetImplemented(SAFARI)
   @NotYetImplemented(IE)
   @NotYetImplemented(EDGE)
-  @NotYetImplemented(FIREFOX)
   void canContinueResponse() throws InterruptedException {
     try (Network network = new Network(driver)) {
       String intercept =
@@ -137,7 +134,6 @@ void canContinueResponse() throws InterruptedException {
   @NotYetImplemented(SAFARI)
   @NotYetImplemented(IE)
   @NotYetImplemented(EDGE)
-  @NotYetImplemented(FIREFOX)
   void canProvideResponse() throws InterruptedException {
     try (Network network = new Network(driver)) {
       String intercept =
@@ -202,7 +198,6 @@ void canProvideResponseWithAllParameters() throws InterruptedException {
   @NotYetImplemented(SAFARI)
   @NotYetImplemented(IE)
   @NotYetImplemented(EDGE)
-  @NotYetImplemented(FIREFOX)
   void canRemoveIntercept() {
     try (Network network = new Network(driver)) {
       String intercept =
@@ -217,7 +212,6 @@ void canRemoveIntercept() {
   @NotYetImplemented(SAFARI)
   @NotYetImplemented(IE)
   @NotYetImplemented(EDGE)
-  @NotYetImplemented(FIREFOX)
   void canContinueWithAuthCredentials() {
     try (Network network = new Network(driver)) {
       network.addIntercept(new AddInterceptParameters(InterceptPhase.AUTH_REQUIRED));
@@ -237,7 +231,6 @@ void canContinueWithAuthCredentials() {
   @NotYetImplemented(SAFARI)
   @NotYetImplemented(IE)
   @NotYetImplemented(EDGE)
-  @NotYetImplemented(FIREFOX)
   void canContinueWithoutAuthCredentials() {
     try (Network network = new Network(driver)) {
       network.addIntercept(new AddInterceptParameters(InterceptPhase.AUTH_REQUIRED));
@@ -257,7 +250,6 @@ void canContinueWithoutAuthCredentials() {
   @NotYetImplemented(SAFARI)
   @NotYetImplemented(IE)
   @NotYetImplemented(EDGE)
-  @NotYetImplemented(FIREFOX)
   void canCancelAuth() {
     try (Network network = new Network(driver)) {
       network.addIntercept(new AddInterceptParameters(InterceptPhase.AUTH_REQUIRED));
@@ -276,7 +268,6 @@ void canCancelAuth() {
   @NotYetImplemented(SAFARI)
   @NotYetImplemented(IE)
   @NotYetImplemented(EDGE)
-  @NotYetImplemented(FIREFOX)
   void canFailRequest() {
     try (Network network = new Network(driver)) {
       network.addIntercept(new AddInterceptParameters(InterceptPhase.BEFORE_REQUEST_SENT));

diff --git a/java/test/org/openqa/selenium/bidi/storage/StorageCommandsTest.java b/java/test/org/openqa/selenium/bidi/storage/StorageCommandsTest.java
@@ -68,7 +68,6 @@ public void setUp() {
   @NotYetImplemented(IE)
   @NotYetImplemented(EDGE)
   @NotYetImplemented(CHROME)
-  @NotYetImplemented(FIREFOX)
   public void canGetCookieByName() {
     String key = generateUniqueKey();
     String value = "set";
@@ -140,7 +139,6 @@ public void canGetCookieInAUserContext() {}
   @NotYetImplemented(IE)
   @NotYetImplemented(EDGE)
   @NotYetImplemented(CHROME)
-  @NotYetImplemented(FIREFOX)
   public void canAddCookie() {
     String key = generateUniqueKey();
     String value = "foo";
@@ -231,7 +229,6 @@ public void canAddAndGetCookie() {
   @NotYetImplemented(IE)
   @NotYetImplemented(EDGE)
   @NotYetImplemented(CHROME)
-  @NotYetImplemented(FIREFOX)
   public void canGetAllCookies() {
     String key1 = generateUniqueKey();
     String key2 = generateUniqueKey();
@@ -307,7 +304,6 @@ public void canDeleteCookieWithName() {
   @NotYetImplemented(IE)
   @NotYetImplemented(EDGE)
   @NotYetImplemented(CHROME)
-  @NotYetImplemented(FIREFOX)
   public void testAddCookiesWithDifferentPathsThatAreRelatedToOurs() {
     driver.get(appServer.whereIs("/common/animals"));