Fixing HtmlUnit driver to pass recently added tests

SeleniumHQ · Jan 25, 2016 · 9312fa1 · 9312fa1
1 parent b0aebbb
commit 9312fa1
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/java/client/src/org/openqa/selenium/htmlunit/HtmlUnitDriver.java b/java/client/src/org/openqa/selenium/htmlunit/HtmlUnitDriver.java
@@ -1102,12 +1102,12 @@ public WebElement findElementByName(String name) {
   }
 
   @Override
-  public List<WebElement> findElementsByName(String using) {
+  public List<WebElement> findElementsByName(String name) {
     if (!(lastPage() instanceof HtmlPage)) {
       return new ArrayList<>();
     }
 
-    List<DomElement> allElements = ((HtmlPage) lastPage()).getElementsByName(using);
+    List<DomElement> allElements = ((HtmlPage) lastPage()).getElementsByName(name);
     return convertRawHtmlElementsToWebElements(allElements);
   }
 
@@ -1126,12 +1126,16 @@ public WebElement findElementByTagName(String name) {
   }
 
   @Override
-  public List<WebElement> findElementsByTagName(String using) {
+  public List<WebElement> findElementsByTagName(String name) {
+    if ("".equals(name)) {
+      throw new InvalidSelectorException("Unable to locate element by xpath for " + lastPage());
+    }
+
     if (!(lastPage() instanceof HtmlPage)) {
       return new ArrayList<>();
     }
 
-    NodeList allElements = ((HtmlPage) lastPage()).getElementsByTagName(using);
+    NodeList allElements = ((HtmlPage) lastPage()).getElementsByTagName(name);
     List<WebElement> toReturn = new ArrayList<>(allElements.getLength());
     for (int i = 0; i < allElements.getLength(); i++) {
       Node item = allElements.item(i);

diff --git a/java/client/test/org/openqa/selenium/TypingTest.java b/java/client/test/org/openqa/selenium/TypingTest.java
@@ -695,7 +695,7 @@ public void canSafelyTypeOnElementThatIsRemovedFromTheDomOnKeyPress() {
   }
 
   @Test
-  @NotYetImplemented({CHROME})
+  @NotYetImplemented({CHROME, HTMLUNIT})
   public void canClearNumberInputAfterTypingInvalidInput() {
     driver.get(pages.formPage);
     WebElement input = driver.findElement(By.id("age"));