js: Fix module loading on Windows

Fixes #642
SeleniumHQ · Jun 15, 2015 · b458a63 · b458a63
1 parent e81ad1d
commit b458a63
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/javascript/node/selenium-webdriver/CHANGES.md b/javascript/node/selenium-webdriver/CHANGES.md
@@ -1,3 +1,7 @@
+## v2.46.1
+
+* Fixed internal module loading on Windows.
+
 ## v2.46.0
 
 * Exposed a new logging API via the `webdriver.logging` module. For usage, see

diff --git a/javascript/node/selenium-webdriver/_base.js b/javascript/node/selenium-webdriver/_base.js
@@ -98,6 +98,9 @@ function Context(opt_configureForTesting) {
     CLOSURE_BASE_PATH: path.dirname(CLOSURE_BASE_FILE_PATH) + '/',
     CLOSURE_IMPORT_SCRIPT: function(src, opt_srcText) {
       if (opt_srcText !== undefined) {
+        // Windows paths use backslashes, which must be properly escaped before
+        // evaluated with vm.runInContext.
+        opt_srcText = opt_srcText.replace(/\\/g, '/');
         vm.runInContext(opt_srcText, closure, src);
       } else {
         loadScript(src);

diff --git a/javascript/node/selenium-webdriver/package.json b/javascript/node/selenium-webdriver/package.json
@@ -1,6 +1,6 @@
 {
   "name": "selenium-webdriver",
-  "version": "2.46.0",
+  "version": "2.46.1",
   "description": "The official WebDriver JavaScript bindings from the Selenium project",
   "keywords": [
     "automation",