-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[grid] Using session request timeout in the RouterServer
When a new session request comes, the Router forwards it to the SessionQueue, and the new session request will stay in the queue up to 300 seconds (default). However, the read timeout in the http client is 180 seconds (default), so the request will timeout in the Router first. Which is why we need to use the configured new session request timeout. Fixes SeleniumHQ/docker-selenium#1377
- Loading branch information
Showing
1 changed file
with
20 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
db2bb9e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@diemol was this perhaps included in 4.0.0-rc-2-prerelease-20210906 ? I'm not seeing it mentioned anywhere.
db2bb9e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the commit hash in the Server version is the reference.
db2bb9e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I somehow missed it.