Fixing clear atom to work with <input type="range"> for IE

SeleniumHQ · Mar 19, 2018 · edbc914 · edbc914
1 parent 56f210e
commit edbc914
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 2 deletions.
diff --git a/javascript/atoms/action.js b/javascript/atoms/action.js
@@ -89,7 +89,13 @@ bot.action.clear = function(element) {
 
   if (element.value) {
     bot.action.LegacyDevice_.focusOnElement(element);
-    element.value = '';
+    if (goog.userAgent.IE && bot.dom.isInputType(element, 'range')) {
+      var min = element.min ? element.min : 0;
+      var max = element.max ? element.max : 100;
+      element.value = (max < min) ? min : min + (max - min) / 2;
+    } else {
+      element.value = '';
+    }
     bot.events.fire(element, bot.events.EventType.CHANGE);
     bot.events.fire(element, bot.events.EventType.BLUR);
     var body = bot.getDocument().body;

diff --git a/javascript/atoms/dom.js b/javascript/atoms/dom.js
@@ -290,6 +290,21 @@ bot.dom.isFileInput = function(element) {
 };
 
 
+/**
+ * @param {!Element} element The element to check.
+ * @param {string} inputType The type of input to check.
+ * @return {boolean} Whether the element is an input with specified type.
+ */
+bot.dom.isInputType = function(element, inputType) {
+  if (bot.dom.isElement(element, goog.dom.TagName.INPUT)) {
+    var type = element.type.toLowerCase();
+    return type == inputType;
+  }
+
+  return false;
+};
+
+
 /**
  * @param {!Element} element The element to check.
  * @return {boolean} Whether the element is contentEditable.
@@ -331,7 +346,9 @@ bot.dom.isContentEditable = function(element) {
  * @return {boolean} Whether the element accepts user-typed text.
  */
 bot.dom.isEditable = function(element) {
-  return (bot.dom.isTextual(element) || bot.dom.isFileInput(element)) &&
+  return (bot.dom.isTextual(element) ||
+          bot.dom.isFileInput(element) ||
+          bot.dom.isInputType(element, 'range')) &&
       !bot.dom.getProperty(element, 'readOnly');
 };