Skip to content

Commit

Permalink
don't comment out the driver service wait!!!!!!!!!!
Browse files Browse the repository at this point in the history
Fixes #1123
  • Loading branch information
lukeis committed Oct 8, 2015
1 parent bf5ea32 commit ffb124c
Showing 1 changed file with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -163,11 +163,11 @@ public void start() throws IOException {
process.copyOutputTo(System.err);
process.executeAsync();

//URL status = new URL(url.toString() + "/status");
//new UrlChecker().waitUntilAvailable(20, SECONDS, status);
//} catch (UrlChecker.TimeoutException e) {
// process.checkForError();
// throw new WebDriverException("Timed out waiting for driver server to start.", e);
URL status = new URL(url.toString() + "/status");
new UrlChecker().waitUntilAvailable(20, SECONDS, status);
} catch (UrlChecker.TimeoutException e) {
process.checkForError();
throw new WebDriverException("Timed out waiting for driver server to start.", e);
} finally {
lock.unlock();
}
Expand Down

2 comments on commit ffb124c

@barancev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! My fault.. :(
But why CI could not catch it, WTF?

@lukeis
Copy link
Member Author

@lukeis lukeis commented on ffb124c Oct 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@barancev because CI uses saucelabs and saucelabs uses chromedriver directly to launch chrome and not the standalone server (but saucelabs does use the standalone server to launch firefox)

Please sign in to comment.