Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding array reduce functionality #7

Closed
Fatxx opened this issue Jun 27, 2017 · 6 comments
Closed

Adding array reduce functionality #7

Fatxx opened this issue Jun 27, 2017 · 6 comments

Comments

@Fatxx
Copy link
Contributor

Fatxx commented Jun 27, 2017

hello @selfrefactor ,

Are you willing to accept an implementation for R.reduce()? Or is it out of scope?

Thank you and keep the good work.

@selfrefactor
Copy link
Owner

Will be implemented before the end of the week.
Thank you for the good words.

@Fatxx
Copy link
Contributor Author

Fatxx commented Jun 28, 2017

Can I open a merge request with this?

@selfrefactor
Copy link
Owner

Sure, you can 👍

@selfrefactor
Copy link
Owner

I check your PR, there are some things to be done, before proceeding to build process and npm publish

My edit will curry initialValue as now it is not handled. After doing this and write a few more test cases, we are ready to proceed further. I am at work now, so I will do that later today.

@Fatxx
Copy link
Contributor Author

Fatxx commented Jun 28, 2017

Ok, great! Thank you.

@selfrefactor
Copy link
Owner

Published to NPM and closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants