Fix slug to follow owner_name/repo_name format #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghengeveld
changed the title
slug to follow <owner_name>/<repo_name> format
ghengeveld
changed the title
slug to follow owner_name/repo_name format
ghengeveld
changed the title
slug to follow owner_name/repo_name format
|
@pvdlg Any chance this can be merged and released? |
|
Can you fix the tests? |
gr2m
requested changes
Oct 18, 2021
Comment on lines
14
to
+16
| buildUrl: `https://bitbucket.org/${env.BITBUCKET_REPO_SLUG}/addon/pipelines/home#!/results/${env.BITBUCKET_BUILD_NUMBER}`, | ||
| branch: env.BITBUCKET_BRANCH, | ||
| slug: env.BITBUCKET_REPO_SLUG, | ||
| slug: env.BITBUCKET_REPO_FULL_NAME, |
There was a problem hiding this comment.
you still use BITBUCKET_REPO_SLUG in line 14, is that intentional?
Given that the issue at #136 didn't have any 👍🏼 and no other issues have been opened, I wonder if this is a non-issue?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #136