-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(publish): use file name as label when multiple #179
fix(publish): use file name as label when multiple #179
Conversation
b544ad4
to
c7f5b5a
Compare
c7f5b5a
to
a74b5da
Compare
I'm not using gitlab myself, so I wouldn't the best to review. Pierre is taking time off. Maybe @travi could review? When in doubt, I'd merge it though. I'd just ask you to watch the repository in case someone reports an issue caused by a regression from your pull request |
i'm not a gitlab user either, so i'm not very familiar with the needs of gitlab either. i agree that it is worth merging to unblock this issue. @nfriend since none of the current maintainers use gitlab, it is admittedly a bit more difficult to support this plugin effectively on our own. would you be interested in helping with this plugin? |
🎉 This PR is included in version 6.0.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@travi I'd be happy to! Let me know how I can help out. |
Thanks for offering to help Nathan! First thing would be to watch the repository. Maybe triage the open issues and pull requests to see if they are still relevant, if you find some time. We want to formalize the process of onboarding contributors/maintainers, but there is some chore work we need to finish first |
awesome, thanks a lot! |
What does this PR do?
Fixes #158 by using the correct property name (
label
) that is used as the link name in the GitLab release.Screenshots
Given a configuration like this:
Before:
When a glob pattern matched multiple files (just
build/**/*
in this example), each matched file was uploaded with the provided name ("Compiled files"), causing a validation error for every file but the first.After:
When a glob pattern matches multiple files, each matched file is uploaded with its file name instead of the provided
label
.Closes #158