Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(publish): use file name as label when multiple #179

Merged

Conversation

nfriend
Copy link
Contributor

@nfriend nfriend commented Nov 24, 2020

What does this PR do?

Fixes #158 by using the correct property name (label) that is used as the link name in the GitLab release.

Screenshots

Given a configuration like this:

{
  "plugins": [
    [
      "@semantic-release/gitlab",
      {
        "assets": [
          { "path": "src/**/*", "label": "Source files" },
          { "path": "build/**/*", "label": "Compiled files" }
        ]
      }
    ]
  ]
}

Before:

When a glob pattern matched multiple files (just build/**/* in this example), each matched file was uploaded with the provided name ("Compiled files"), causing a validation error for every file but the first.

before

After:

When a glob pattern matches multiple files, each matched file is uploaded with its file name instead of the provided label.

after


Closes #158

@nfriend nfriend force-pushed the nfriend-fix-mutli-asset-labels branch from c7f5b5a to a74b5da Compare November 30, 2020 16:42
@nfriend
Copy link
Contributor Author

nfriend commented Nov 30, 2020

@gr2m @pvdlg @travi Would one of you mind reviewing this PR and merging if it looks good to you (when you have time)? 🙏

Apologies for the ping, I'm not sure what the normal process is to request a review 🤔

Thanks!

@gr2m
Copy link
Member

gr2m commented Nov 30, 2020

I'm not using gitlab myself, so I wouldn't the best to review. Pierre is taking time off. Maybe @travi could review?

When in doubt, I'd merge it though. I'd just ask you to watch the repository in case someone reports an issue caused by a regression from your pull request

@travi
Copy link
Member

travi commented Dec 1, 2020

i'm not a gitlab user either, so i'm not very familiar with the needs of gitlab either. i agree that it is worth merging to unblock this issue.

@nfriend since none of the current maintainers use gitlab, it is admittedly a bit more difficult to support this plugin effectively on our own. would you be interested in helping with this plugin?

@travi travi merged commit 81cd6a8 into semantic-release:master Dec 1, 2020
@github-actions
Copy link

github-actions bot commented Dec 1, 2020

🎉 This PR is included in version 6.0.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nfriend
Copy link
Contributor Author

nfriend commented Dec 1, 2020

would you be interested in helping with this plugin?

@travi I'd be happy to! Let me know how I can help out.

@gr2m
Copy link
Member

gr2m commented Dec 1, 2020

Thanks for offering to help Nathan! First thing would be to watch the repository. Maybe triage the open issues and pull requests to see if they are still relevant, if you find some time.

We want to formalize the process of onboarding contributors/maintainers, but there is some chore work we need to finish first

@nfriend
Copy link
Contributor Author

nfriend commented Dec 3, 2020

@gr2m Sounds good! I've done an initial pass through the open issues and will continue to watch the activity going forward. I'll also try and push to resolve some of the bugs on GitLab's side (in particular, #223832).

@gr2m
Copy link
Member

gr2m commented Dec 3, 2020

awesome, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An error occurred while running semantic-release: HTTPError: Response code 400 (Bad Request)
3 participants