feat: support asset type and filepath

[yxonic]

Implemented two options for assets according to GitLab document on asset permanent link and link type, addressing #161.

It can also be a solution to #167, with which now we can download asset using URL like this: https://host/namespace/project/releases/v1.0.0/downloads/build.tar.gz

[nfriend]

@yxonic This looks great! Thanks for putting this PR together.

I have one small suggestion on the current changes. I also think we should cover this new field in a test, most likely in publish.test.js.

Back to you for now 🏓 Feel free to ping me when this is ready for another review!

[yxonic]

@nfriend thanks for your time reviewing the code! I've made several changes according to your suggestions:

1. I agree with your comments, so link_type is now undefined as default, which also fixes tests.
2. Added a testcase to cover these fields. I'm not exactly sure if I did it right, so if there's any problem, just let me know :)

[nfriend]

@yxonic Looking great! Thanks for the changes and for adding the test.

I did find one usability issue that I think we should address, which I've mentioned below.

Also, I think we should log the type and filepath when in debug mode on lines 54-55 in publish.js (for some reason GitHub doesn't let me comment on the lines directly - I guess I'm just too used to GitLab 😅).

Let me know what you think. And please let me know if you need help with any of the suggested changes. I realize I'm probably requesting more changes than you originally bargained for 😄

[yxonic]

@nfriend Hi~ I just fixed the links. Regarding the duplicate filepath issue, I took a slightly different approach here. I noticed that label is basically ignored when there are more than one files, and I think we can do the same for filepath for consistency: filepath will still work when there is only one file matched (user can still use *), and won't break the pipeline if more than one file is matched later. This behavior is also documented and tested.

[nfriend]

@yxonic Sorry for the slow response here, I'm going to try and get to this tomorrow!

[nfriend]

Regarding the duplicate filepath issue, I took a slightly different approach here.

@yxonic Good call! This is a simpler and more consistent solution 👍 And thanks for documenting this behavior.

[nfriend]

@yxonic This looks good to me! Just gave this a try in a test project and it works great. Thanks for all your work here!

[github-actions]

🎉 This PR is included in version 6.2.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀