Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move prettier to devDependencies #487

Merged
merged 3 commits into from
Jan 30, 2023

Conversation

mat813
Copy link
Contributor

@mat813 mat813 commented Jan 29, 2023

It is not used anywhere in the code and is only needed during development.

Also, some people, like me, depend on a fork of prettier and now, depending on the order the dependencies get installed, either the fork or the original get used, which makes ci/cd a nightmare because builds gets unreproducible.

It is not used anywhere in the code and is only needed during
development.
@fgreinacher fgreinacher changed the title Move prettier to devDependencies fix: move prettier to devDependencies Jan 30, 2023
Copy link
Contributor

@fgreinacher fgreinacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@fgreinacher fgreinacher merged commit 40d3b2e into semantic-release:master Jan 30, 2023
@github-actions
Copy link

🎉 This PR is included in version 10.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants