Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename read-pkg-up to read-package-up #671

Merged
merged 4 commits into from
Jun 18, 2024

Conversation

MrGadget1024
Copy link
Contributor

Fixes #642
See also discussion: semantic-release/semantic-release#3352

Copy link
Member

@travi travi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@travi
Copy link
Member

travi commented Jun 16, 2024

@MrGadget1024 the build failures suggest that the lockfile isnt fully up to date with the change. mind double checking that part of the update?

- someone already added read-package-up with the correct integrity about 37 lines up
- someone already added read-package-up with the correct integrity about 37 lines up
@MrGadget1024
Copy link
Contributor Author

@MrGadget1024 the build failures suggest that the lockfile isnt fully up to date with the change. mind double checking that part of the update?

Let's see if that makes it happy

@travi travi merged commit 687ba5a into semantic-release:master Jun 18, 2024
5 checks passed
@gr2m
Copy link
Member

gr2m commented Jun 19, 2024

Hmm the release failed: https://github.com/semantic-release/release-notes-generator/actions/runs/9564890549/job/26366631394 I'm confused about what's happening here, any ideas?

@MrGadget1024
Copy link
Contributor Author

A search only finds read-pkg-up in one place:

image

Something is cached someplace?

image

@travi
Copy link
Member

travi commented Jun 21, 2024

the problem here is that the release step uses the version of release-notes-generator that is a dependency of semantic-release, not the unreleased local version with this change. i'm confused why npm isnt still installing the proper dependency tree for semantic-release after this change. @MrGadget1024 to help us understand, was your lockfile modification done manually or by the npm cli?

@travi
Copy link
Member

travi commented Jun 21, 2024

i think #677 will resolve the broken release process

@MrGadget1024
Copy link
Contributor Author

was your lockfile modification done manually or by the npm cli?

Manual search and replace file edit. The package name changed..same version, the package with the new name was added but no one ever changed the pointers to that one.

@travi
Copy link
Member

travi commented Jun 21, 2024

gotcha. that at least makes sense for what happened here. this is one of the cases where we needed npm's ability to have multiple versions of the same package in the same overall dependency tree.

  • we needed the published version of release-notes-generator that semantic-release depended on in order to install and the local version which hadnt been published yet.
  • the published version still depended on the old package that had been removed for the local version.
  • semantic-release used in the release process still needed the old version.

the safest way to update a lockfile is always to let the npm cli handle the updates so that it sorts out the details like this. sometimes, npm does get a lockfile wrong or only partially updated. i know the first attempt for this PR resulted in an invalid lockfile, so i totally understand resorting to manually updating in the second attempt. my fix PR should have things resolved by updating the lockfile again with the npm cli

sorry that this made things more complex, but thanks again for the contribution!

@gr2m
Copy link
Member

gr2m commented Jun 22, 2024

Copy link

🎉 This PR is included in version 14.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated dependency read-pkg-up
3 participants