Skip to content
This repository has been archived by the owner on Aug 20, 2020. It is now read-only.

feat: Added type definitions #93

Merged
merged 3 commits into from
Feb 19, 2020
Merged

feat: Added type definitions #93

merged 3 commits into from
Feb 19, 2020

Conversation

Strum355
Copy link
Contributor

@Strum355 Strum355 commented Oct 4, 2018

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

Added type definitions for lib/client.js

@SendGridDX
Copy link

SendGridDX commented Oct 4, 2018

CLA assistant check
All committers have signed the CLA.

@thinkingserious
Copy link
Contributor

Hello @Strum355,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

Copy link

@alfredlucero alfredlucero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the typing!

@thinkingserious
Copy link
Contributor

Hello @Strum355,

Thanks again for the PR!

You have earned 6 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold or to simply continue the celebration.

Also, please be sure you have officially registered with us here by November 1, 2018 to qualify.

If you have any questions you can email us at [email protected].

Thank you and Happy Hacktobering!

Team SendGrid

@Strum355
Copy link
Contributor Author

Strum355 commented Aug 8, 2019

@alfredlucero hey any chance this could get merged? :) im trying to clean up forked repos and ive a few waiting for a PR to be merged that i cant delete 😄

@thinkingserious thinkingserious changed the title Added type definitions feat: Added type definitions Feb 19, 2020
@thinkingserious thinkingserious merged commit d63f709 into sendgrid:master Feb 19, 2020
@thinkingserious
Copy link
Contributor

Hello @Strum355,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants