Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: node version upgrade, axios upgrade #1391

Merged
merged 7 commits into from
Nov 30, 2023
Merged

Conversation

shrutiburman
Copy link
Contributor

Fixes

This PR:
Drops support for node v 6, 8, 10

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket.

@shrutiburman shrutiburman merged commit 8a7e4eb into main Nov 30, 2023
13 checks passed
@shrutiburman shrutiburman deleted the security-update branch November 30, 2023 07:40
@tovbinm
Copy link

tovbinm commented Dec 4, 2023

@tiwarishubham635 @manisha1997 can you please trigger a release for this version?

@jakebanks
Copy link

jakebanks commented Dec 8, 2023

Is anyone else getting axios3 is not a function or similar when calling send() since updating? (i'm on 8.1.0)

I patched Axios in one of our repos recently and discovered they'd updated the default export (see comment).

So my imports changed from

const axios = require('axios');

to

const axios = require('axios').default;

Don't know enough about JS modules to understand if this change is also required here.

@Capta1nRaj
Copy link

Never till launch.

@Capta1nRaj
Copy link

Is anyone else getting axios3 is not a function or similar when calling send() since updating? (i'm on 8.1.0)

I patched Axios in one of our repos recently and discovered they'd updated the default export (see comment).

So my imports changed from

const axios = require('axios');

to

const axios = require('axios').default;

Don't know enough about JS modules to understand if this change is also required here.

Can you share your axios verion?

"@sendgrid/mail": "^8.0.0",
"axios": "^1.6.2",

these are mine

@jakebanks
Copy link

Is anyone else getting axios3 is not a function or similar when calling send() since updating? (i'm on 8.1.0)
I patched Axios in one of our repos recently and discovered they'd updated the default export (see comment).
So my imports changed from

const axios = require('axios');

to

const axios = require('axios').default;

Don't know enough about JS modules to understand if this change is also required here.

Can you share your axios verion?

"@sendgrid/mail": "^8.0.0",
"axios": "^1.6.2",

these are mine

Sure, I'm using

@sendgrid/mail at 8.1.0
axios 1.6.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants