Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support IEnumerable<KeyValuePair<string, string>> in SerilogLoggerScope #193

Closed
admalledd opened this issue Jul 22, 2021 · 1 comment
Closed

Comments

@admalledd
Copy link

In EnrichAndCreateScopeItem() if my TState was originally created as Dictionary<string, string> the if statement fails to pivot my items into LogEvent.Properties as expected.

Similar to #186 but not quite, though if work on either is done, probably best to do both enhancements?

A reason why I am using <string, string> is that I want to be sure at time of BeginScope that all key/values are properly string-ified as expected for eventual SQL (or other tablized, like Splunk, AzureTableStorage...) column-store.

@nblumhardt
Copy link
Member

Thanks for the suggestion; at this time I don't think there's enough momentum behind this usage to warrant making a change, but I can see how it would be a useful - thanks again for raising it, will keep it in mind in the future 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants