Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to current sdk #138

Merged
merged 3 commits into from
May 2, 2019
Merged

move to current sdk #138

merged 3 commits into from
May 2, 2019

Conversation

SimonCropp
Copy link
Contributor

No description provided.

@nblumhardt
Copy link
Member

Looks like appveyor might not yet have that SDK installed? The build scripts, once upon a time, would install the target SDK, but I think life turned out simpler relying on an installed version :-)

@SimonCropp
Copy link
Contributor Author

fixed it. TBH I find the use of global.json to be too restrictive for people contributing. i omit that file from my repos, and just ensure the CI server has a new enough SDK on it

@nblumhardt
Copy link
Member

Thanks Simon! 👍

@nblumhardt nblumhardt merged commit 7332262 into serilog:dev May 2, 2019
@nblumhardt nblumhardt mentioned this pull request Aug 19, 2019
@nblumhardt nblumhardt added this to the 3.0.0 milestone Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants