Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#285] Bump text package after 2.0.1 (to 2.0.2) #283

Merged
merged 4 commits into from
Jun 23, 2023
Merged

[#285] Bump text package after 2.0.1 (to 2.0.2) #283

merged 4 commits into from
Jun 23, 2023

Commits on Jun 23, 2023

  1. [#285] Update the rewrite rules for text 

    Problem: after `2.0.1` version they rewrote `pack` completely, so now
our tricks with folding `pack`/`unpack`'s internals do not work.

For details, see [this commit in `text`
package](haskell/text@5a666e4).

Fortunately, annihilating entire `pack` and `unpack` calls is still an
option. Along with that `pack` rewrite they added `NOINLINE [0]` pragma
for `pack`, meaning that we have even better chances of the rewrite rule
to fire.

Solution: add a `MIN_VERSION` pragma to disable the now non-working
rewrite rule in the recent `text` versions.
Rely on the remaining `unpack (pack s) = s` and `pack (unpack s) = s`
rewrite rules to fire at stage 0.

Update maintenance notes, in the new reality verifying whether `text`
bump is correct should be simpler.
    @Martoon-00
    Martoon-00 committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    7e3dbbf View commit details
    Browse the repository at this point in the history

  2. [#285] Bump the allowed upper version of text 

    Problem: after the last commit it is safe to allow the recent
`text-2.0.2`.

Solution: allow it.
    @Martoon-00
    Martoon-00 committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    5147a0a View commit details
    Browse the repository at this point in the history

  3. [Chore] Comment out the Stackage badges 

    Problem: universum was excluded from the LTS, and xrefcheck complains on
badges containing invalid links.

Solution: comment those badges out, create a ticket for restoring the
things.
    @Martoon-00
    Martoon-00 committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    70292d3 View commit details
    Browse the repository at this point in the history

  4. [#285] Update the comment in tests 

    Problem: after the large rewrite of `text` package (where it started
keeping UTF-8 instead of UTF-16) some things changed.

E.g. the code point mentioned in the comment is different now, and the
link to the `text`'s source code is not more actual.

Solution: strip the details that has to be maintained.

It all seems pretty clear without them.
    @Martoon-00
    Martoon-00 committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    e24aade View commit details
    Browse the repository at this point in the history