-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish always all modules #249
Comments
Hey @vanniktech , Yeah, I've thought about that initially when I split things up into modules, but then I thought, wouldn't it just be confusing if a new module version is published w/o any changes? Did you try to use the bom and only specify the version there? W/o specifying the individual module's versions? |
That's how every library that I use does it. It's what I'm used to from okio, ktor, multiplatform-settings, sqldelight and many more.
Not yet. The bom version would then be |
The bom and core faker version is always the same. So try to use the latest version of the bom, it will pull the latest core faker version + versions for other modules that you include as dependency.
I guess they just haven't figured out a way to publish modules independently 😆 The bom actually solves that problem, because it contains all the modules' versions: https://repo1.maven.org/maven2/io/github/serpro69/kotlin-faker-bom/2.0.0-rc.6/kotlin-faker-bom-2.0.0-rc.6.pom |
But I will also consider your proposal 👍 One thing I don't like about the current setup is that the repo contains a ton of tags 🤣 |
The bom doesn't help in that case, either, right? |
Well, yeah, you still need to update the version. And unless you're hard-coding versions in dependency notation strings for each module, which obviously no one does, you only need to update version in one place either way. What I meant was more from like "communication" (can't find a right word for it) perspective. Like, it's a bit misleading that there's a new version available, which actually isn't new at all, right? Of course this should probably be solved via release notes. Thanks for the good questions! :) It's definitely something to think about and I will address this before a stable release is made. But do try the BOM at least for now, it should solve your immediate problem :) |
Maybe. I'm just used to it though.
Yup, thanks! |
OK, I'm convinced 😁 simply because having a ton of useless tags in a repo makes me sick 🤢 |
I was just using the core module and wanted to also add the lorem one:
Only to find out that it needs to be
2.0.0-rc.4
. Would it be possible for you to just publish all the modules, even if there are no new changes? That's also how retrofit/sqldelight and other libraries do it.The text was updated successfully, but these errors were encountered: