-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add commands for SCF Alias #39
Conversation
@@ -235,3 +235,15 @@ actions: | |||
type: string | |||
remove: | |||
definition: Remove your Express.js application | |||
list_alias: | |||
definition: Show your aliases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I remember it right, in yesterday's product meeting, we have decided to use Chinese for all the descriptions in serverless.component.yml
and have a plan to auto-generate configuration.md
according to this file.
Will it be better if we start using Chinese definitions now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If use Chinese to describe the COMMANDs,i need the descriptions from @tinafangkunding
@Jominja You should update version of tencent-component-toolkit to latest version in package.json. |
|
||
const scf = new Scf(credentials, region) | ||
|
||
const scfOutput = await scf.publishVersion(publish_params) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Publish version of SCF is an asynchronous flow, maybe you should wait for the Active
status of SCF.
return listAlias | ||
} catch (e) { | ||
return { | ||
requestId: e.reqId, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All errors except api error in components code should throw TypeError
like:
throw new TypeError(
'xxx',
`xxx`
)
If you do not throw error, users will get success status even though they get the error message for cli.
## [0.1.9](v0.1.8...v0.1.9) (2020-11-02) ### Bug Fixes * add commands for SCF Alias ([#39](#39)) ([e939be3](e939be3))
🎉 This PR is included in version 0.1.9 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
No description provided.