Skip to content
This repository has been archived by the owner on Mar 20, 2024. It is now read-only.

commit message rewriting breaks with signed commits #79

Closed
cgwalters opened this issue Jan 11, 2017 · 3 comments
Closed

commit message rewriting breaks with signed commits #79

cgwalters opened this issue Jan 11, 2017 · 3 comments

Comments

@cgwalters
Copy link

See projectatomic/container-storage-setup#179 ➡️ projectatomic/container-storage-setup@f7a3746

@Manishearth
Copy link
Member

I was going to say that we never call git-filter-branch directly, and rebase handles this, so it's probably a bug in a git python lib we use, but it turns out we do use filter-branch 😄

@cgwalters
Copy link
Author

Our previous Homu instance was on Fedora 23 (yes really) with an old git, but our new one (f25) has a version of git which has the fix for this.

So yes, anyone who hits this - upgrade your git.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants