Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tests using revoked.badssl.com #146

Merged
merged 1 commit into from
Aug 5, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions tests/test_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -133,16 +133,9 @@ class FailureHost:
host="revoked.badssl.com",
error_messages=[
# macOS
# "“revoked.badssl.com” certificate is revoked",
"“revoked.badssl.com” certificate is revoked",
# Windows
# "The certificate is revoked.",
# TODO: Temporary while certificate is expired on badssl.com.
# Test will start failing against once the certificate is fixed.
# macOS
'"revoked.badssl.com","RapidSSL TLS DV RSA Mixed SHA256 2020 CA-1","DigiCert Global Root CA" certificates do not meet pinning requirements',
"“revoked.badssl.com” certificate is expired",
# Windows
"A required certificate is not within its validity period when verifying against the current system clock or the timestamp in the signed file.",
"The certificate is revoked.",
],
)
)
Expand Down
Loading