Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

native-tls 0.2.10 MSRV raised to 1.53.0 #222

Open
NinoScript opened this issue Apr 20, 2022 · 2 comments
Open

native-tls 0.2.10 MSRV raised to 1.53.0 #222

NinoScript opened this issue Apr 20, 2022 · 2 comments

Comments

@NinoScript
Copy link

This change added for byte in bytes { which fails with in Rust < 1.53.

Error message
error[E0277]: `[u8; 10]` is not an iterator
   --> /edited-out/.cargo/registry/src/github.com-1ecc6299db9ec823/native-tls-0.2.10/src/imp/security_framework.rs:197:17
    |
197 |     for byte in bytes {
    |                 ^^^^^ borrow the array with `&` or call `.iter()` on it to iterate over it
    |
    = help: the trait `Iterator` is not implemented for `[u8; 10]`
    = note: arrays are not iterators, but slices like the following are: `&[1, 2, 3]`
    = note: required because of the requirements on the impl of `IntoIterator` for `[u8; 10]`
    = note: required by `into_iter`

Borrowing the array (for byte in &bytes {) would allow this crate to keep working in older Rust versions.
IMO, it's ok if you decide not to work with older Rust versions, but I did want to let you know.

@sfackler
Copy link
Owner

Sure, happy to take a PR changing that and ratcheting the MSRV back down.

@NinoScript
Copy link
Author

There you go 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants