-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove timezone support from sas_numeric_to_date()
#583
Comments
The implementation in #584 doesn't remove timezone support but gives a warning when it's used with any timezone other than UTC. |
I'm reviewing #584 and want to make sure I understand:
|
|
While working on #582, there was an issue with timezone tests in
sas_numeric_to_date()
.Looking at https://communities.sas.com/t5/Ask-the-Expert/Tips-and-Tricks-for-Working-with-Dates-and-Times-in-SAS-Q-amp-A/ta-p/813974, it appears that SAS likely (but not definitively) doesn't support storing time zones and it likely stores the timezone as the current time zone. The documentation that I can find is not clear.
Therefore, I plan to remove timezone support from the function and always use UTC timezones. That seems like the least-bad choice because a SAS file sent to a computer in a timezone that has different daylight saving time method would likely get different results, based on my reading.
The text was updated successfully, but these errors were encountered: