-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: avoid using deprecated ctx.resolve_tools #459
Conversation
0fc3313
to
6ff37bb
Compare
See bazelbuild/bazel#22249 for context. Signed-off-by: Tiago Quelhas <[email protected]>
Quality Gate passedIssues Measures |
@sgammon Are we getting a new release anytime soon? For now, Bazel has to patch rules_graalvm to make sure we can upgrade to Bazel 8: https://github.com/bazelbuild/bazel/blob/aa397cf37d7d013740b4081c19bef38b992b3eab/MODULE.bazel#L64-L69, other users probably have to do the same. |
@meteorcloudy IIRC release couldn't happen last time it was attempted (at least at the latest version of GraalVM) because of unstable download URLs. those may have been fixed now, so it's worth a retry. is the patch above applied because there hasn't been a release to BCR, or because there hasn't been a release in general? If it's sufficient to release to the GH repo only, that can be very quick |
We can skip this check on BCR presubmit.
Yes, ideally there should be a new version on BCR containing this fix. |
See the same breakage of rules_graalvm in bazelbuild/bazel-central-registry#3260 |
@meteorcloudy In this case the unstable download URLs were GraalVM's own URLs... unless that's what you mean? I do think they have likely fixed them now (we needed at least one I'm out for the holiday today but I can take this on once I'm back (probably Sun or Mon). Thanks for your patience and for explaining. |
No worries, Bazel itself is fine for now, I'm just worried other rules_graalvm might hit this after Bazel 8 release (which will happen next week). Thanks for taking a look! |
See bazelbuild/bazel#22249 for context.
Fixes #458.