Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid using deprecated ctx.resolve_tools #459

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

tjgq
Copy link
Contributor

@tjgq tjgq commented Sep 16, 2024

See bazelbuild/bazel#22249 for context.

Fixes #458.

@tjgq tjgq force-pushed the resolve-tools branch 2 times, most recently from 0fc3313 to 6ff37bb Compare September 16, 2024 13:20
@tjgq tjgq changed the title Avoid using the deprecated ctx.resolve_tools in the native_image rule. fix: avoid using deprecated ctx.resolve_tools Sep 16, 2024
@tjgq tjgq marked this pull request as ready for review September 16, 2024 13:21
@tjgq tjgq requested a review from sgammon as a code owner September 16, 2024 13:21
Copy link

sonarcloud bot commented Sep 16, 2024

@sgammon sgammon merged commit 07d43c2 into sgammon:main Sep 19, 2024
72 of 75 checks passed
@sgammon sgammon added this to the 1.0.0 milestone Sep 19, 2024
@sgammon sgammon added the bug Something isn't working label Sep 19, 2024
@sgammon sgammon self-assigned this Sep 19, 2024
@meteorcloudy
Copy link
Contributor

@sgammon Are we getting a new release anytime soon? For now, Bazel has to patch rules_graalvm to make sure we can upgrade to Bazel 8: https://github.com/bazelbuild/bazel/blob/aa397cf37d7d013740b4081c19bef38b992b3eab/MODULE.bazel#L64-L69, other users probably have to do the same.

@sgammon
Copy link
Owner

sgammon commented Nov 27, 2024

@meteorcloudy IIRC release couldn't happen last time it was attempted (at least at the latest version of GraalVM) because of unstable download URLs. those may have been fixed now, so it's worth a retry.

is the patch above applied because there hasn't been a release to BCR, or because there hasn't been a release in general? If it's sufficient to release to the GH repo only, that can be very quick

@meteorcloudy
Copy link
Contributor

because of unstable download URLs.

We can skip this check on BCR presubmit.

is the patch above applied because there hasn't been a release to BCR

Yes, ideally there should be a new version on BCR containing this fix.

@meteorcloudy
Copy link
Contributor

See the same breakage of rules_graalvm in bazelbuild/bazel-central-registry#3260

@sgammon
Copy link
Owner

sgammon commented Nov 28, 2024

@meteorcloudy In this case the unstable download URLs were GraalVM's own URLs... unless that's what you mean? I do think they have likely fixed them now (we needed at least one 23.x point-release so that the archive URLs exist, and I believe that has taken place).

I'm out for the holiday today but I can take this on once I'm back (probably Sun or Mon). Thanks for your patience and for explaining.

@meteorcloudy
Copy link
Contributor

No worries, Bazel itself is fine for now, I'm just worried other rules_graalvm might hit this after Bazel 8 release (which will happen next week). Thanks for taking a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Migrate for --incompatible_disallow_ctx_resolve_tools
3 participants