updated use hook to now allow pulling in the entire object

sghsri · Apr 25, 2024 · 17af446 · 17af446 · github-actions · Apr 25, 2024
1 parent 63d36a8
commit 17af446
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 9 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "chrome-extension-toolkit",
-  "version": "0.0.71",
+  "version": "0.0.72",
   "description": "A template for creating npm packages using TypeScript and VSCode",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",

diff --git a/src/storage/createStore.ts b/src/storage/createStore.ts
@@ -306,13 +306,16 @@ function createStore<T>(
             arguments.length === 2 ? defaultValue : key === null ? defaults : defaults[key]
         );
 
-        const onChange = useCallback(({ key: k, newValue }: DataChange<T>) => {
-            if (key === null) {
-                setValue(prev => ({ ...prev, [k]: newValue } as any));
-            } else {
-                setValue(newValue as any);
-            }
-        }, []);
+        const onChange = useCallback(
+            ({ key: k, newValue }: DataChange<T>) => {
+                if (key === null) {
+                    setValue(prev => ({ ...prev, [k]: newValue } as any));
+                } else {
+                    setValue(newValue as any);
+                }
+            },
+            [key, setValue]
+        );
 
         useEffect(() => {
             if (key === null) {
@@ -328,7 +331,7 @@ function createStore<T>(
                     store.unsubscribe(onChange as any);
                 };
             }
-        }, []);
+        }, [key, onChange]);
 
         const set = async newValue => {
             if (key === null) {