Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hook_demo_plugin_render_editlink not working #1646

Closed
Knah-Tsaeb opened this issue Nov 17, 2020 · 4 comments · Fixed by #1727
Closed

hook_demo_plugin_render_editlink not working #1646

Knah-Tsaeb opened this issue Nov 17, 2020 · 4 comments · Fixed by #1727
Labels
bug it's broken! plugin bells and whistles

Comments

@Knah-Tsaeb
Copy link

Hi, in the demo plugin, the function hook_demo_plugin_render_editlink not working in 0.12.1.
The extra field data is not save.

@nodiscc
Copy link
Member

nodiscc commented Aug 10, 2022

@Knah-Tsaeb do you still have this problem? Can you provide a way to reproduce the problem (example plugin?)

@Knah-Tsaeb
Copy link
Author

@nodiscc of course.

  • install fresh Shaarli (docker or regular install)
  • enable plugin demo
  • add new link or note
  • fill the last input (Demo Stuff)
  • save
  • edit the previous link or note
  • the last input is blank

@nodiscc
Copy link
Member

nodiscc commented Aug 11, 2022

Thanks! I could reproduce with v0.12.1 installed from zip. The value of the last input does not seem to be saved. No relevant messages in logs even with dev.debug = true.

@ArthurHoaro
Copy link
Member

This issue should be fixed by changes embedded in #1727. I'll see if I can get back into it and merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug it's broken! plugin bells and whistles
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants