Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX: Improve HTTP request accessor #2045

Open
ArthurHoaro opened this issue Nov 25, 2023 · 0 comments
Open

DX: Improve HTTP request accessor #2045

ArthurHoaro opened this issue Nov 25, 2023 · 0 comments
Labels
cleanup code cleanup and refactoring
Milestone

Comments

@ArthurHoaro
Copy link
Member

Follow-up of #1972 (review)

With the latest upgrade to Slim 4, we retrieve query and payload parameters, with $object->getArray()['key'] ?? 'default'.
This is not great for readability and maintainability, and could easily be improved with either:

  • a simple helper function
  • a wrapper around requests object

Whichever solution can make the code better and is relatively easy to set up.

@ArthurHoaro ArthurHoaro added the cleanup code cleanup and refactoring label Nov 25, 2023
@ArthurHoaro ArthurHoaro added this to the 0.14.0 milestone Nov 25, 2023
@nodiscc nodiscc modified the milestones: 0.14.0, 2.0.0 Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup code cleanup and refactoring
Projects
None yet
Development

No branches or pull requests

2 participants