Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up add_overall() #68

Open
ddsjoberg opened this issue Jan 5, 2022 · 0 comments
Open

Speed up add_overall() #68

ddsjoberg opened this issue Jan 5, 2022 · 0 comments

Comments

@ddsjoberg
Copy link
Collaborator

The add_overall() function is pretty slow. It's slow because I am re-running the slowest parts of the function multiple times: calculating the complete data.

But this can be updated by updating the complete data, rather than re-calculating it each time. This will take a major refactoring of .complete_ae_data(), internals of all tbl_ae*() functions, and of add_overall().

This is a low priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant